Bug 81726 - [BlackBerry] Remove redundant code in SocketStreamHandler
Summary: [BlackBerry] Remove redundant code in SocketStreamHandler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Charles Wei
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-20 19:46 PDT by Charles Wei
Modified: 2012-03-21 00:30 PDT (History)
6 users (show)

See Also:


Attachments
Patch to remove redundant code in SocketStreamHandle (3.67 KB, patch)
2012-03-20 19:56 PDT, Charles Wei
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Wei 2012-03-20 19:46:48 PDT
platform/network/blackberry/SocketStreamHandle.h

   void didReceiveAuthenticationChallenge(const AuthenticationChallenge&);
    void receivedCredential(const AuthenticationChallenge&, const Credential&);
    void receivedRequestToContinueWithoutCredential(const AuthenticationChallenge&);
    void receivedCancellation(const AuthenticationChallenge&);

are not needed and not called from anywhere, with empty implementation.  Need to remove them since that's what MAC and CURL network porting uses,  we use different mechanism for authentication.
Comment 1 Charles Wei 2012-03-20 19:56:54 PDT
Created attachment 132951 [details]
Patch to remove redundant code in SocketStreamHandle
Comment 2 Charles Wei 2012-03-20 20:03:49 PDT
Internal: 145049
Comment 3 WebKit Review Bot 2012-03-21 00:30:16 PDT
Comment on attachment 132951 [details]
Patch to remove redundant code in SocketStreamHandle

Clearing flags on attachment: 132951

Committed r111507: <http://trac.webkit.org/changeset/111507>
Comment 4 WebKit Review Bot 2012-03-21 00:30:21 PDT
All reviewed patches have been landed.  Closing bug.