Bug 81722 – compute the sign of flexibility for new flexbox

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tony Chang]

compute the sign of flexibility for new flexbox

[Tony Chang]

Created attachment 132931 [details]
Patch

[Tony Chang]

The ChangeLog links to the relevant part of the spec.

[Build Bot]

Comment on attachment 132931 [details]
Patch

Attachment 132931 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12035169

[Tony Chang]

Created attachment 133067 [details]
Patch

[Tony Chang]

As discussed offline, rather than adding a new loop, we compute the min/max applied size when we're computing the not min/max applied size. This should be a bit more efficient.

[Ojan Vafai]

Comment on attachment 133067 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133067&action=review

> Source/WebCore/rendering/RenderFlexibleBox.cpp:744
> +        Length maxLength = isHorizontalFlow() ? child->style()->maxWidth() : child->style()->maxHeight();
> +        if (maxLength.isSpecified() && childMinMaxAppliedMainAxisExtent > valueForLength(maxLength, flexboxAvailableContentExtent))
> +            childMinMaxAppliedMainAxisExtent = valueForLength(maxLength, flexboxAvailableContentExtent);
> +        Length minLength = isHorizontalFlow() ? child->style()->minWidth() : child->style()->minHeight();
> +        if (minLength.isSpecified() && childMinMaxAppliedMainAxisExtent < valueForLength(minLength, flexboxAvailableContentExtent))
> +            childMinMaxAppliedMainAxisExtent = valueForLength(minLength, flexboxAvailableContentExtent);

As discussed in person, I'm pretty sure this does the wrong thing for percentages. I think we may want to use RenderBox::computeLogicalHeightUsing and RenderBox::computeLogicalWidthInRegionUsing, but I'm not sure.

In either case, I'm fine with committing this now with a FIXME. Would be good to get Hyatt's thoughts on the right way to do this.

[Tony Chang]

Created attachment 133084 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 133084 [details]
Patch for landing

Clearing flags on attachment: 133084

Committed r111596: <http://trac.webkit.org/changeset/111596>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.