Bug 81717 - Update ANGLE in WebKit
Summary: Update ANGLE in WebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-03-20 16:23 PDT by Dean Jackson
Modified: 2012-03-27 12:22 PDT (History)
3 users (show)

See Also:


Attachments
Patch (478.59 KB, patch)
2012-03-26 18:08 PDT, Dean Jackson
kbr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2012-03-20 16:23:49 PDT
ANGLE is currently r1000+ while ToT is r939. This is causing failures such as https://bugs.webkit.org/show_bug.cgi?id=70989.
Comment 1 Dean Jackson 2012-03-20 16:24:13 PDT
Chromium must import a different version of ANGLE?
Comment 2 Radar WebKit Bug Importer 2012-03-20 16:24:23 PDT
<rdar://problem/11086369>
Comment 3 Kenneth Russell 2012-03-26 12:53:35 PDT
(In reply to comment #1)
> Chromium must import a different version of ANGLE?

Yes, Chromium frequently pulls in the latest version of ANGLE via its multiple repository management tool, gclient. See the angle-related variable in http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?view=markup .
Comment 4 Dean Jackson 2012-03-26 18:08:53 PDT
Created attachment 133951 [details]
Patch
Comment 5 Kenneth Russell 2012-03-26 18:31:24 PDT
Comment on attachment 133951 [details]
Patch

Looks good as long as it compiles and has been tested. r=me
Comment 6 Dean Jackson 2012-03-26 18:41:32 PDT
(In reply to comment #5)
> (From update of attachment 133951 [details])
> Looks good as long as it compiles and has been tested. r=me

Yep, thanks.

I'll let the EWS bots run through just in case. Ignore all the style errors.
Comment 7 Dean Jackson 2012-03-27 12:22:07 PDT
Committed r112300: <http://trac.webkit.org/changeset/112300>