Bug 81713 - [chromium] Convert TouchFlingPlatformGestureCurve to a 2-D Bezier for better control of curve shape.
Summary: [chromium] Convert TouchFlingPlatformGestureCurve to a 2-D Bezier for better ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: W. James MacLean
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-20 16:14 PDT by W. James MacLean
Modified: 2012-03-20 19:06 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.63 KB, patch)
2012-03-20 16:23 PDT, W. James MacLean 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description W. James MacLean 2012-03-20 16:14:48 PDT 
[chromium] Convert TouchFlingPlatformGestureCurve to a 2-D Bezier for better control of curve shape.
Comment 1 W. James MacLean 2012-03-20 16:23:22 PDT 
Created attachment 132924 [details]
Patch
Comment 2 W. James MacLean 2012-03-20 16:24:20 PDT 
(In reply to comment #1)
> Created an attachment (id=132924) [details]
> Patch

The patch to rename this class will follow (maybe tomorrow morning at this point).
Comment 3 Nat Duca 2012-03-20 18:18:13 PDT 
Comment on attachment 132924 [details]
Patch

Unofficially LGTM. Does @davemoore <3 this?
Comment 4 Dirk Pranke 2012-03-20 18:20:29 PDT 
Comment on attachment 132924 [details]
Patch

stylistically the patch looks fine; normally I wouldn't touch a patch in this area with a ten foot pole, but nduca says it looks good ...
Comment 5 W. James MacLean 2012-03-20 18:23:45 PDT 
(In reply to comment #3)
> (From update of attachment 132924 [details])
> Unofficially LGTM. Does @davemoore <3 this?

Yes, Dave has seen and thought it was good (not to speak for him of course!). Rob and Alex and I are happier with it than any of the other candidates - it feels pretty good.
Comment 6 WebKit Review Bot 2012-03-20 19:06:28 PDT 
Comment on attachment 132924 [details]
Patch

Clearing flags on attachment: 132924

Committed r111483: <http://trac.webkit.org/changeset/111483>
Comment 7 WebKit Review Bot 2012-03-20 19:06:32 PDT 
All reviewed patches have been landed.  Closing bug.