RESOLVED FIXED 81702
Sandboxed PluginProcess should use private temporary and cache directories 
https://bugs.webkit.org/show_bug.cgi?id=81702
Summary Sandboxed PluginProcess should use private temporary and cache directories
Alexey Proskuryakov
Reported 2012-03-20 14:46:47 PDT
<rdar://problem/10792047>
Attachments
proposed patch (7.62 KB, patch)
2012-03-20 14:55 PDT, Alexey Proskuryakov 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2012-03-20 14:55:05 PDT
Created attachment 132904 [details] proposed patch
Darin Adler
Comment 2 2012-03-20 15:49:10 PDT
Comment on attachment 132904 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=132904&action=review > Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:107 > + static char temporaryDirectory[PATH_MAX]; Why static?
Alexey Proskuryakov
Comment 3 2012-03-20 15:58:44 PDT
Comment on attachment 132904 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=132904&action=review >> Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:107 >> + static char temporaryDirectory[PATH_MAX]; > > Why static? No good reason. Will remove.
Anders Carlsson
Comment 4 2012-03-20 16:20:39 PDT
Comment on attachment 132904 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=132904&action=review > Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:105 > + String systemDirectorySuffix = "com.apple.WebKit.PluginProcess+" + PluginProcess::shared().pluginBundleIdentifier(); I think you should just call PluginProcess::shared().netscapePluginModule()->module()->bundleIdentifier(); directly here.
Alexey Proskuryakov
Comment 5 2012-03-20 16:31:32 PDT
Committed <http://trac.webkit.org/changeset/111463>.
Note You need to log in before you can comment on or make changes to this bug.