Bug 81702 - Sandboxed PluginProcess should use private temporary and cache directories
Summary: Sandboxed PluginProcess should use private temporary and cache directories
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-20 14:46 PDT by Alexey Proskuryakov
Modified: 2012-03-20 16:31 PDT (History)
2 users (show)

See Also:


Attachments
proposed patch (7.62 KB, patch)
2012-03-20 14:55 PDT, Alexey Proskuryakov
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2012-03-20 14:46:47 PDT
<rdar://problem/10792047>
Comment 1 Alexey Proskuryakov 2012-03-20 14:55:05 PDT
Created attachment 132904 [details]
proposed patch
Comment 2 Darin Adler 2012-03-20 15:49:10 PDT
Comment on attachment 132904 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132904&action=review

> Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:107
> +    static char temporaryDirectory[PATH_MAX];

Why static?
Comment 3 Alexey Proskuryakov 2012-03-20 15:58:44 PDT
Comment on attachment 132904 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132904&action=review

>> Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:107
>> +    static char temporaryDirectory[PATH_MAX];
> 
> Why static?

No good reason. Will remove.
Comment 4 Anders Carlsson 2012-03-20 16:20:39 PDT
Comment on attachment 132904 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132904&action=review

> Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:105
> +    String systemDirectorySuffix = "com.apple.WebKit.PluginProcess+" + PluginProcess::shared().pluginBundleIdentifier();

I think you should just call PluginProcess::shared().netscapePluginModule()->module()->bundleIdentifier(); directly here.
Comment 5 Alexey Proskuryakov 2012-03-20 16:31:32 PDT
Committed <http://trac.webkit.org/changeset/111463>.