Bug 81678 – Make distributeExtraLogicalHeightToRows return the consumed logical height

• Status: RESOLVED
• Resolution: FIXED
• Component: Tables

[Julien Chaffraix]

Currently this function returns the remaining logical height. This is painful as the distribution algorithm is interested in consumed logical height to decrease the available logical height. This also means that there will be a need for some unneeded house-keeping.

Let's change that.

[Julien Chaffraix]

Created attachment 132847 [details]
Proposed fix 1.

[Tony Chang]

Comment on attachment 132847 [details]
Proposed fix 1.

View in context: https://bugs.webkit.org/attachment.cgi?id=132847&action=review

> Source/WebCore/rendering/RenderTableSection.cpp:427
> -int RenderTableSection::distributeExtraLogicalHeightToPercentRows(int extraLogicalHeight, int totalPercent)
> +void RenderTableSection::distributeExtraLogicalHeightToPercentRows(int& extraLogicalHeight, int totalPercent)

Nit: Maybe we should reverse the parameter order. I think in/out params normally come last.

> Source/WebCore/rendering/RenderTableSection.cpp:454
> -int RenderTableSection::distributeExtraLogicalHeightToAutoRows(int extraLogicalHeight, unsigned autoRowsCount)
> +void RenderTableSection::distributeExtraLogicalHeightToAutoRows(int& extraLogicalHeight, unsigned autoRowsCount)

Ditto.

[WebKit Review Bot]

Comment on attachment 132847 [details]
Proposed fix 1.

Attachment 132847 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12009301

New failing tests:
fast/dom/error-to-string-stack-overflow.html

[Julien Chaffraix]

Comment on attachment 132847 [details]
Proposed fix 1.

View in context: https://bugs.webkit.org/attachment.cgi?id=132847&action=review

The test failing is unrelated to my change (I am hitting it locally without the patch).

>> Source/WebCore/rendering/RenderTableSection.cpp:427
>> +void RenderTableSection::distributeExtraLogicalHeightToPercentRows(int& extraLogicalHeight, int totalPercent)
> 
> Nit: Maybe we should reverse the parameter order. I think in/out params normally come last.

I prefer it this way as it looks like |totalPercent| is an added parameter compared to distributeExtraLogicalHeightToRows.

[Julien Chaffraix]

Committed r111435: <http://trac.webkit.org/changeset/111435>