RESOLVED FIXED 81672
[BlackBerry] Allow simulator to use GLES2 acceleration 
https://bugs.webkit.org/show_bug.cgi?id=81672
Summary [BlackBerry] Allow simulator to use GLES2 acceleration
Filip Spacek
Reported 2012-03-20 09:08:33 PDT
Any hardware acceleration is only enabled on device build. The Simulator now has GLES2 drivers so we should be able to turn it on in simulator too. The patch makes it possible to enable GLES2 support with an environment variable.
Attachments
proposed patch (2.92 KB, patch)
2012-03-20 09:11 PDT, Filip Spacek 		rwlbuis: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (2.95 KB, patch)
2012-04-09 11:38 PDT, Ming Xie 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Spacek
Comment 1 2012-03-20 09:11:52 PDT
Created attachment 132837 [details] proposed patch
Rob Buis
Comment 2 2012-03-20 09:15:43 PDT
Comment on attachment 132837 [details] proposed patch LGTM.
WebKit Review Bot
Comment 3 2012-03-20 09:17:59 PDT
Comment on attachment 132837 [details] proposed patch Rejecting attachment 132837 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ucceeded at 1 with fuzz 3. patching file Source/cmake/OptionsBlackBerry.cmake Hunk #1 FAILED at 19. Hunk #2 succeeded at 121 with fuzz 1. 1 out of 2 hunks FAILED -- saving rejects to file Source/cmake/OptionsBlackBerry.cmake.rej patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/Scripts/webkitdirs.pm Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12001348
Ming Xie
Comment 4 2012-04-09 11:38:21 PDT
Created attachment 136275 [details] Patch
Rob Buis
Comment 5 2012-04-09 11:39:30 PDT
Comment on attachment 136275 [details] Patch LGTM.
WebKit Review Bot
Comment 6 2012-04-09 15:40:19 PDT
Comment on attachment 136275 [details] Patch Clearing flags on attachment: 136275 Committed r113633: <http://trac.webkit.org/changeset/113633>
Rob Buis
Comment 7 2013-01-04 02:20:30 PST
This landed a long time ago, so close.
Note You need to log in before you can comment on or make changes to this bug.