WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 81666
(
r110063
) m_mouseDownMayStartDrag is used without being behind the ENABLE(DRAG_SUPPORT) macro
https://bugs.webkit.org/show_bug.cgi?id=81666
Summary
(r110063) m_mouseDownMayStartDrag is used without being behind the ENABLE(DRA...
Konrad Piascik
Reported
2012-03-20 08:19:52 PDT
(
r110063
) m_mouseDownMayStartDrag is used without being behind the ENABLE(DRAG_SUPPORT) macro
Attachments
Patch
(1.82 KB, patch)
2012-03-20 08:21 PDT
,
Konrad Piascik
no flags
Details
Formatted Diff
Diff
Patch
(1.71 KB, patch)
2012-03-20 08:31 PDT
,
Konrad Piascik
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Konrad Piascik
Comment 1
2012-03-20 08:21:35 PDT
Created
attachment 132828
[details]
Patch
Rob Buis
Comment 2
2012-03-20 08:23:49 PDT
Comment on
attachment 132828
[details]
Patch Better do it like this: if (m_mousePressed && m_mouseDownMayStartSelect && #if ENABLE(DRAG_SUPPORT) !m_mouseDownMayStartDrag && #endif m_frame->selection()->isCaretOrRange() && !m_capturingMouseEventsNode)
Konrad Piascik
Comment 3
2012-03-20 08:31:38 PDT
Created
attachment 132831
[details]
Patch
Rob Buis
Comment 4
2012-03-20 08:36:34 PDT
Comment on
attachment 132831
[details]
Patch Better :)
WebKit Review Bot
Comment 5
2012-03-20 09:18:14 PDT
Comment on
attachment 132831
[details]
Patch Clearing flags on attachment: 132831 Committed
r111400
: <
http://trac.webkit.org/changeset/111400
>
WebKit Review Bot
Comment 6
2012-03-20 09:18:18 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug