Bug 81666 - (r110063) m_mouseDownMayStartDrag is used without being behind the ENABLE(DRAG_SUPPORT) macro
Summary: (r110063) m_mouseDownMayStartDrag is used without being behind the ENABLE(DRA...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-20 08:19 PDT by Konrad Piascik
Modified: 2012-03-20 09:18 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.82 KB, patch)
2012-03-20 08:21 PDT, Konrad Piascik
no flags Details | Formatted Diff | Diff
Patch (1.71 KB, patch)
2012-03-20 08:31 PDT, Konrad Piascik
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Konrad Piascik 2012-03-20 08:19:52 PDT
(r110063) m_mouseDownMayStartDrag is used without being behind the ENABLE(DRAG_SUPPORT) macro
Comment 1 Konrad Piascik 2012-03-20 08:21:35 PDT
Created attachment 132828 [details]
Patch
Comment 2 Rob Buis 2012-03-20 08:23:49 PDT
Comment on attachment 132828 [details]
Patch

Better do it like this:

if (m_mousePressed && m_mouseDownMayStartSelect && 
#if ENABLE(DRAG_SUPPORT)
    !m_mouseDownMayStartDrag &&
#endif
     m_frame->selection()->isCaretOrRange() && !m_capturingMouseEventsNode)
Comment 3 Konrad Piascik 2012-03-20 08:31:38 PDT
Created attachment 132831 [details]
Patch
Comment 4 Rob Buis 2012-03-20 08:36:34 PDT
Comment on attachment 132831 [details]
Patch

Better :)
Comment 5 WebKit Review Bot 2012-03-20 09:18:14 PDT
Comment on attachment 132831 [details]
Patch

Clearing flags on attachment: 132831

Committed r111400: <http://trac.webkit.org/changeset/111400>
Comment 6 WebKit Review Bot 2012-03-20 09:18:18 PDT
All reviewed patches have been landed.  Closing bug.