RESOLVED FIXED 81650
[BlackBerry] Upstreaming blackberry specific css file 
https://bugs.webkit.org/show_bug.cgi?id=81650
Summary [BlackBerry] Upstreaming blackberry specific css file
Charles Wei
Reported 2012-03-20 04:55:58 PDT
Need to upstreaming BlackBerry-specific css files mediaControlsBlackBerry.css themeBlackBerry.css at : Source/WebCore/css
Attachments
Patch (9.40 KB, patch)
2012-03-20 21:28 PDT, Jonathan Dong 		no flags
DetailsFormatted DiffDiff
Patch (9.47 KB, patch)
2012-03-20 22:49 PDT, Jonathan Dong 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Dong
Comment 1 2012-03-20 21:28:54 PDT
Created attachment 132966 [details] Patch
WebKit Review Bot
Comment 2 2012-03-20 21:30:48 PDT
Attachment 132966 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:12: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2012-03-20 21:34:55 PDT
Comment on attachment 132966 [details] Patch Attachment 132966 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12090134
Jonathan Dong
Comment 4 2012-03-20 22:49:29 PDT
Created attachment 132974 [details] Patch
Charles Wei
Comment 5 2012-03-20 23:49:47 PDT
Comment on attachment 132974 [details] Patch LGTM. Need a webkit reviewer to approve this though.
Nikolas Zimmermann
Comment 6 2012-03-21 02:30:17 PDT
Comment on attachment 132974 [details] Patch I didn't check the actual css files for correctness, I trust you this is okay, r=me.
Charles Wei
Comment 7 2012-03-21 02:33:59 PDT
Comment on attachment 132974 [details] Patch submit to commitbot after the approval from Nikolas.
WebKit Review Bot
Comment 8 2012-03-21 03:09:47 PDT
Comment on attachment 132974 [details] Patch Clearing flags on attachment: 132974 Committed r111518: <http://trac.webkit.org/changeset/111518>
WebKit Review Bot
Comment 9 2012-03-21 03:09:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.