Bug 81650 - [BlackBerry] Upstreaming blackberry specific css file
Summary: [BlackBerry] Upstreaming blackberry specific css file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Dong
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-20 04:55 PDT by Charles Wei
Modified: 2012-03-21 03:09 PDT (History)
7 users (show)

See Also:


Attachments
Patch (9.40 KB, patch)
2012-03-20 21:28 PDT, Jonathan Dong
no flags Details | Formatted Diff | Diff
Patch (9.47 KB, patch)
2012-03-20 22:49 PDT, Jonathan Dong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Wei 2012-03-20 04:55:58 PDT
Need to upstreaming BlackBerry-specific css files 

mediaControlsBlackBerry.css
themeBlackBerry.css 

at : Source/WebCore/css
Comment 1 Jonathan Dong 2012-03-20 21:28:54 PDT
Created attachment 132966 [details]
Patch
Comment 2 WebKit Review Bot 2012-03-20 21:30:48 PDT
Attachment 132966 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:12:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2012-03-20 21:34:55 PDT
Comment on attachment 132966 [details]
Patch

Attachment 132966 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12090134
Comment 4 Jonathan Dong 2012-03-20 22:49:29 PDT
Created attachment 132974 [details]
Patch
Comment 5 Charles Wei 2012-03-20 23:49:47 PDT
Comment on attachment 132974 [details]
Patch

LGTM.  Need a webkit reviewer to approve this though.
Comment 6 Nikolas Zimmermann 2012-03-21 02:30:17 PDT
Comment on attachment 132974 [details]
Patch

I didn't check the actual css files for correctness, I trust you this is okay, r=me.
Comment 7 Charles Wei 2012-03-21 02:33:59 PDT
Comment on attachment 132974 [details]
Patch

submit to commitbot after the approval from Nikolas.
Comment 8 WebKit Review Bot 2012-03-21 03:09:47 PDT
Comment on attachment 132974 [details]
Patch

Clearing flags on attachment: 132974

Committed r111518: <http://trac.webkit.org/changeset/111518>
Comment 9 WebKit Review Bot 2012-03-21 03:09:52 PDT
All reviewed patches have been landed.  Closing bug.