WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 81636
[EFL] Change returned view mode in case of NULL of ewkView.
https://bugs.webkit.org/show_bug.cgi?id=81636
Summary
[EFL] Change returned view mode in case of NULL of ewkView.
Krzysztof Czech
Reported
2012-03-20 01:17:37 PDT
Function ewk_view_mode_get returns wrong view mode in case of NULL of ewkView.
Attachments
Change returned view mode in case of NULL of ewkView
(1.96 KB, patch)
2012-03-20 01:23 PDT
,
Krzysztof Czech
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Krzysztof Czech
Comment 1
2012-03-20 01:23:11 PDT
Created
attachment 132777
[details]
Change returned view mode in case of NULL of ewkView
Gyuyoung Kim
Comment 2
2012-03-20 01:49:41 PDT
Comment on
attachment 132777
[details]
Change returned view mode in case of NULL of ewkView LGTM.
Grzegorz Czajkowski
Comment 3
2012-03-20 03:20:47 PDT
LGTM.
Raphael Kubo da Costa (:rakuco)
Comment 4
2012-03-20 06:18:03 PDT
Comment on
attachment 132777
[details]
Change returned view mode in case of NULL of ewkView Looks good, thanks.
Krzysztof Czech
Comment 5
2012-03-22 07:50:59 PDT
CCing reviewers.
Eric Seidel (no email)
Comment 6
2012-03-22 07:56:38 PDT
Comment on
attachment 132777
[details]
Change returned view mode in case of NULL of ewkView I'm happy to rubber-stamp this, I know next-to-nothing about EFL however.
WebKit Review Bot
Comment 7
2012-03-22 08:18:13 PDT
Comment on
attachment 132777
[details]
Change returned view mode in case of NULL of ewkView Clearing flags on attachment: 132777 Committed
r111703
: <
http://trac.webkit.org/changeset/111703
>
WebKit Review Bot
Comment 8
2012-03-22 08:18:19 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug