Bug 81635 - Let CSSImageValue inherit directly from CSSValue.
Summary: Let CSSImageValue inherit directly from CSSValue.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-20 00:58 PDT by Andreas Kling
Modified: 2012-03-20 05:38 PDT (History)
5 users (show)

See Also:

Attachments
Patch (14.28 KB, patch)
2012-03-20 01:11 PDT, Andreas Kling 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch vee too (19.37 KB, patch)
2012-03-20 04:52 PDT, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2012-03-20 00:58:59 PDT 
CSSImageValue currently inherits from CSSPrimitiveValue. To aid in style value refactoring we should simplify this to inheriting directly from CSSValue.
Comment 1 Andreas Kling 2012-03-20 01:11:25 PDT 
Created attachment 132776 [details]
Patch
Comment 2 WebKit Review Bot 2012-03-20 02:15:31 PDT 
Comment on attachment 132776 [details]
Patch

Attachment 132776 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12007164

New failing tests:
fast/dom/setPrimitiveValue.html
Comment 3 Antti Koivisto 2012-03-20 03:03:13 PDT 
Comment on attachment 132776 [details]
Patch

Looks good but the bot is whiny.
Comment 4 Andreas Kling 2012-03-20 04:52:49 PDT 
Created attachment 132802 [details]
Patch vee too

Additional testage.
Comment 5 Antti Koivisto 2012-03-20 05:07:45 PDT 
Comment on attachment 132802 [details]
Patch vee too

r=me
Comment 6 Andreas Kling 2012-03-20 05:38:58 PDT 
Committed r111387: <http://trac.webkit.org/changeset/111387>