RESOLVED FIXED 81635
Let CSSImageValue inherit directly from CSSValue. 
https://bugs.webkit.org/show_bug.cgi?id=81635
Summary Let CSSImageValue inherit directly from CSSValue.
Andreas Kling
Reported 2012-03-20 00:58:59 PDT
CSSImageValue currently inherits from CSSPrimitiveValue. To aid in style value refactoring we should simplify this to inheriting directly from CSSValue.
Attachments
Patch (14.28 KB, patch)
2012-03-20 01:11 PDT, Andreas Kling 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch vee too (19.37 KB, patch)
2012-03-20 04:52 PDT, Andreas Kling 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2012-03-20 01:11:25 PDT
Created attachment 132776 [details] Patch
WebKit Review Bot
Comment 2 2012-03-20 02:15:31 PDT
Comment on attachment 132776 [details] Patch Attachment 132776 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12007164 New failing tests: fast/dom/setPrimitiveValue.html
Antti Koivisto
Comment 3 2012-03-20 03:03:13 PDT
Comment on attachment 132776 [details] Patch Looks good but the bot is whiny.
Andreas Kling
Comment 4 2012-03-20 04:52:49 PDT
Created attachment 132802 [details] Patch vee too Additional testage.
Antti Koivisto
Comment 5 2012-03-20 05:07:45 PDT
Comment on attachment 132802 [details] Patch vee too r=me
Andreas Kling
Comment 6 2012-03-20 05:38:58 PDT
Committed r111387: <http://trac.webkit.org/changeset/111387>
Note You need to log in before you can comment on or make changes to this bug.