http://build.webkit.org/results/Lion%20Intel%20Debug%20(WebKit2%20Tests)/r111273%20(5061)/jquery/core-pretty-diff.html http://build.webkit.org/results/Lion%20Intel%20Debug%20(WebKit2%20Tests)/r111273%20(5061)/jquery/event-pretty-diff.html http://build.webkit.org/results/Lion%20Intel%20Debug%20(WebKit2%20Tests)/r111273%20(5061)/jquery/manipulation-pretty-diff.html http://build.webkit.org/results/Lion%20Intel%20Debug%20(WebKit2%20Tests)/r111273%20(5061)/jquery/traversing-pretty-diff.html Unfortunately, due to the state of the tests, I am not sure when this started.
<rdar://problem/11078649>
Added them to the Skipped list in http://trac.webkit.org/changeset/111286
Created attachment 163614 [details] patch
Comment on attachment 163614 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=163614&action=review > LayoutTests/ChangeLog:9 > + 6 seconds is harsh for some jquery test cases. > + Therefore, adjusted the value same as WK1 does. This does not describe the change you are making to LayoutTests. This should read something like "Unskip jQuery tests which will now consistently pass due to the increased waitUntilDone timeout", or some such. > Tools/ChangeLog:9 > + 6 seconds is harsh for some jquery test cases. > + Therefore, adjusted the value same as WK1 does. I think it's unfortunate that we have single tests that take six seconds, but since they're imported I guess there's not much we can do. jQuery is capitalized like so. The second line should read "Therefore, adjust the value to match DumpRenderTree". > Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:58 > +const double TestRunner::waitToDumpWatchdogTimerInterval = 30; Fine with me.
(In reply to comment #4) > (From update of attachment 163614 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=163614&action=review > > > LayoutTests/ChangeLog:9 > > + 6 seconds is harsh for some jquery test cases. > > + Therefore, adjusted the value same as WK1 does. > > This does not describe the change you are making to LayoutTests. This should read something like "Unskip jQuery tests which will now consistently pass due to the increased waitUntilDone timeout", or some such. > > > Tools/ChangeLog:9 > > + 6 seconds is harsh for some jquery test cases. > > + Therefore, adjusted the value same as WK1 does. > > I think it's unfortunate that we have single tests that take six seconds, but since they're imported I guess there's not much we can do. > > jQuery is capitalized like so. > > The second line should read "Therefore, adjust the value to match DumpRenderTree". > > > Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:58 > > +const double TestRunner::waitToDumpWatchdogTimerInterval = 30; > > Fine with me. Thx for the review!!
Created attachment 163754 [details] patch Done!
Created attachment 163755 [details] patch My name besides 'review : +' looks weird so try again!
Comment on attachment 163755 [details] patch Rejecting attachment 163755 [details] from commit-queue. kangil.han@samsung.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
(In reply to comment #8) > (From update of attachment 163755 [details]) > Rejecting attachment 163755 [details] from commit-queue. > > kangil.han@samsung.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. > > - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. > > - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Oh.. my mistake again.. Will get back with '?'. :-(
Created attachment 163757 [details] patch Try again!
Comment on attachment 163757 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=163757&action=review > Tools/ChangeLog:6 > + Reviewed by Tim Horton. The bot would have Done The Right Thing(TM) (and put whoever r+'d this patch's name in here). Just notes for next time!
(In reply to comment #11) > (From update of attachment 163757 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=163757&action=review > > > Tools/ChangeLog:6 > > + Reviewed by Tim Horton. > > The bot would have Done The Right Thing(TM) (and put whoever r+'d this patch's name in here). Just notes for next time! Oh, I see. Thx! I rushed off. ;-)
Comment on attachment 163757 [details] patch Clearing flags on attachment: 163757 Committed r128395: <http://trac.webkit.org/changeset/128395>
All reviewed patches have been landed. Closing bug.