Bug 81597 – [Chromium] IndexedDB: Expose necessary IDB exception codes through WebKit API

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Joshua Bell]

[Chromium] IndexedDB: Expose necessary IDB exception codes through WebKit API

[Joshua Bell]

Created attachment 132727 [details]
Patch

[Joshua Bell]

fishd@ can you review?

[WebKit Review Bot]

Please wait for approval from [e-mail] before submitting because this patch contains changes to the Chromium public API.

[Darin Fisher (:fishd, Google)]

Comment on attachment 132727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132727&action=review

> Source/WebKit/chromium/public/WebIDBDatabaseException.h:34
> +#include "platform/WebCommon.h"

nit: looks like you can do away with this include

> Source/WebKit/chromium/public/WebIDBDatabaseException.h:38
> +// These values must match WebCore::IDBDatabaseException values

we usually don't leave comments like these in the header files.  if someone renames
IDBDatabaseException, they are probably unlikely to search for, find and then revise
this comment.

[Joshua Bell]

Created attachment 132872 [details]
Patch for landing

[Joshua Bell]

(In reply to comment #4)
> (From update of attachment 132727 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=132727&action=review
> 
> > Source/WebKit/chromium/public/WebIDBDatabaseException.h:34
> > +#include "platform/WebCommon.h"
> 
> nit: looks like you can do away with this include

Done...
 
> > Source/WebKit/chromium/public/WebIDBDatabaseException.h:38
> > +// These values must match WebCore::IDBDatabaseException values
> 
> we usually don't leave comments like these in the header files.  if someone renames
> IDBDatabaseException, they are probably unlikely to search for, find and then revise
> this comment.

... and done.

[WebKit Review Bot]

Comment on attachment 132872 [details]
Patch for landing

Rejecting attachment 132872 [details] from commit-queue.

New failing tests:
fast/dom/error-to-string-stack-overflow.html
Full output: http://queues.webkit.org/results/12047004

[Joshua Bell]

Comment on attachment 132872 [details]
Patch for landing

Failure was unrelated; retrying cq

[WebKit Review Bot]

Comment on attachment 132872 [details]
Patch for landing

Rejecting attachment 132872 [details] from commit-queue.

New failing tests:
fast/dom/error-to-string-stack-overflow.html
Full output: http://queues.webkit.org/results/12035087

[Joshua Bell]

Comment on attachment 132872 [details]
Patch for landing

Trying again, hoping the fast/dom/error-to-string-stack-overflow.html test issue has been cleared up.

[WebKit Review Bot]

Comment on attachment 132872 [details]
Patch for landing

Clearing flags on attachment: 132872

Committed r111552: <http://trac.webkit.org/changeset/111552>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.