Bug 81597 - [Chromium] IndexedDB: Expose necessary IDB exception codes through WebKit API
Summary: [Chromium] IndexedDB: Expose necessary IDB exception codes through WebKit API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-19 17:05 PDT by Joshua Bell
Modified: 2012-03-21 09:36 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.64 KB, patch)
2012-03-19 17:08 PDT, Joshua Bell 		no flags Details | Formatted Diff | Diff
Patch for landing (5.53 KB, patch)
2012-03-20 12:08 PDT, Joshua Bell 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-03-19 17:05:47 PDT 
[Chromium] IndexedDB: Expose necessary IDB exception codes through WebKit API
Comment 1 Joshua Bell 2012-03-19 17:08:50 PDT 
Created attachment 132727 [details]
Patch
Comment 2 Joshua Bell 2012-03-19 17:09:30 PDT 
fishd@ can you review?
Comment 3 WebKit Review Bot 2012-03-19 17:11:38 PDT 
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 4 Darin Fisher (:fishd, Google) 2012-03-20 11:25:22 PDT 
Comment on attachment 132727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132727&action=review

> Source/WebKit/chromium/public/WebIDBDatabaseException.h:34
> +#include "platform/WebCommon.h"

nit: looks like you can do away with this include

> Source/WebKit/chromium/public/WebIDBDatabaseException.h:38
> +// These values must match WebCore::IDBDatabaseException values

we usually don't leave comments like these in the header files.  if someone renames
IDBDatabaseException, they are probably unlikely to search for, find and then revise
this comment.
Comment 5 Joshua Bell 2012-03-20 12:08:06 PDT 
Created attachment 132872 [details]
Patch for landing
Comment 6 Joshua Bell 2012-03-20 12:13:35 PDT 
(In reply to comment #4)
> (From update of attachment 132727 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=132727&action=review
> 
> > Source/WebKit/chromium/public/WebIDBDatabaseException.h:34
> > +#include "platform/WebCommon.h"
> 
> nit: looks like you can do away with this include

Done...
 
> > Source/WebKit/chromium/public/WebIDBDatabaseException.h:38
> > +// These values must match WebCore::IDBDatabaseException values
> 
> we usually don't leave comments like these in the header files.  if someone renames
> IDBDatabaseException, they are probably unlikely to search for, find and then revise
> this comment.

... and done.
Comment 7 WebKit Review Bot 2012-03-20 13:16:04 PDT 
Comment on attachment 132872 [details]
Patch for landing

Rejecting attachment 132872 [details] from commit-queue.

New failing tests:
fast/dom/error-to-string-stack-overflow.html
Full output: http://queues.webkit.org/results/12047004
Comment 8 Joshua Bell 2012-03-20 14:16:11 PDT 
Comment on attachment 132872 [details]
Patch for landing

Failure was unrelated; retrying cq
Comment 9 WebKit Review Bot 2012-03-20 16:31:49 PDT 
Comment on attachment 132872 [details]
Patch for landing

Rejecting attachment 132872 [details] from commit-queue.

New failing tests:
fast/dom/error-to-string-stack-overflow.html
Full output: http://queues.webkit.org/results/12035087
Comment 10 Joshua Bell 2012-03-21 08:56:01 PDT 
Comment on attachment 132872 [details]
Patch for landing

Trying again, hoping the fast/dom/error-to-string-stack-overflow.html test issue has been cleared up.
Comment 11 WebKit Review Bot 2012-03-21 09:36:49 PDT 
Comment on attachment 132872 [details]
Patch for landing

Clearing flags on attachment: 132872

Committed r111552: <http://trac.webkit.org/changeset/111552>
Comment 12 WebKit Review Bot 2012-03-21 09:36:54 PDT 
All reviewed patches have been landed.  Closing bug.