Bug 81595 - webkitpy: clean up some port._filesystem references to not reference private members
Summary: webkitpy: clean up some port._filesystem references to not reference private ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks: 71380
  Show dependency tree / graph
 
Reported: 2012-03-19 16:54 PDT by Dirk Pranke
Modified: 2012-03-19 18:26 PDT (History)
5 users (show)

See Also:

Attachments
Patch (11.64 KB, patch)
2012-03-19 16:55 PDT, Dirk Pranke 		no flags Details | Formatted Diff | Diff
fix nit in write_image_diff_files() as well (11.77 KB, patch)
2012-03-19 17:01 PDT, Dirk Pranke 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-03-19 16:54:54 PDT 
webkitpy: clean up some port._filesystem references to not reference private members
Comment 1 Dirk Pranke 2012-03-19 16:55:31 PDT 
Created attachment 132722 [details]
Patch
Comment 2 Dirk Pranke 2012-03-19 17:01:23 PDT 
Created attachment 132725 [details]
fix nit in write_image_diff_files() as well
Comment 3 Eric Seidel (no email) 2012-03-19 17:16:58 PDT 
Comment on attachment 132725 [details]
fix nit in write_image_diff_files() as well

View in context: https://bugs.webkit.org/attachment.cgi?id=132725&action=review

OK.

> Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:71
> -                if port.host.filesystem.exists(expected_filename):
> +                if self._filesystem.exists(expected_filename):

In general getting away from using "port" for these sorts of things seems good.  The goal being to make "port" less of the hub/god object.
Comment 4 Dirk Pranke 2012-03-19 18:26:03 PDT 
Committed r111289: <http://trac.webkit.org/changeset/111289>