Bug 81590 - Remove support for "magic" iframe
: Remove support for "magic" iframe
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
: 81453
  Show dependency treegraph
 
Reported: 2012-03-19 16:31 PST by
Modified: 2012-03-20 10:44 PST (History)


Attachments
Patch (47.97 KB, patch)
2012-03-19 16:36 PST, Adam Barth
no flags Review Patch | Details | Formatted Diff | Diff
Patch (77.80 KB, patch)
2012-03-19 21:06 PST, Adam Barth
no flags Review Patch | Details | Formatted Diff | Diff
Patch (80.53 KB, patch)
2012-03-19 21:13 PST, Adam Barth
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-03-19 16:31:28 PST
Remove support for "magic" iframe
------- Comment #1 From 2012-03-19 16:36:59 PST -------
Created an attachment (id=132713) [details]
Patch
------- Comment #2 From 2012-03-19 16:39:46 PST -------
This will be SOSO awesome if it lands before next Tuesday m19 branch point :)!
------- Comment #3 From 2012-03-19 16:48:28 PST -------
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
------- Comment #4 From 2012-03-19 16:48:50 PST -------
Attachment 132713 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/loader/FrameLoaderClient.h:259:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/loader/FrameLoaderClient.h:259:  The parameter name "ownerElement" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
------- Comment #5 From 2012-03-19 17:00:40 PST -------
(From update of attachment 132713 [details])
Thanks a lot Adam for doing this patch!

WebFrameLoader::didAdoptURLLoader(..) should also be removed.
There are layout tests as well, but they should fail on EWS and their names are very obviously-magic-iframe-related.
------- Comment #6 From 2012-03-19 17:24:31 PST -------
(From update of attachment 132713 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=132713&action=review

> Source/WebKit/chromium/public/WebFrameClient.h:-289
> -    // This frame adopted the resource that is being loaded. This happens when
> -    // an iframe, that is loading a subresource, is transferred between windows.
> -    virtual void didAdoptURLLoader(WebURLLoader*) { }

Yeah, we need to remove the implementation of this function on the Chromium side.
------- Comment #7 From 2012-03-19 21:02:32 PST -------
(From update of attachment 132713 [details])
Attachment 132713 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/11994070
------- Comment #8 From 2012-03-19 21:05:31 PST -------
(From update of attachment 132713 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=132713&action=review

>> Source/WebKit/chromium/public/WebFrameClient.h:-289
>> -    virtual void didAdoptURLLoader(WebURLLoader*) { }
> 
> Yeah, we need to remove the implementation of this function on the Chromium side.

LGTM for nuking this method.
------- Comment #9 From 2012-03-19 21:06:01 PST -------
Created an attachment (id=132751) [details]
Patch
------- Comment #10 From 2012-03-19 21:09:59 PST -------
Attachment 132751 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
Source/WebCore/loader/FrameLoaderClient.h:259:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/loader/FrameLoaderClient.h:259:  The parameter name "ownerElement" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
------- Comment #11 From 2012-03-19 21:13:39 PST -------
Created an attachment (id=132752) [details]
Patch
------- Comment #12 From 2012-03-19 21:17:56 PST -------
Attachment 132752 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
Source/WebCore/loader/FrameLoaderClient.h:259:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/loader/FrameLoaderClient.h:259:  The parameter name "ownerElement" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
------- Comment #13 From 2012-03-19 21:27:07 PST -------
(From update of attachment 132752 [details])
Huge win!  Thanks!
------- Comment #14 From 2012-03-19 22:58:57 PST -------
(From update of attachment 132752 [details])
Clearing flags on attachment: 132752

Committed r111361: <http://trac.webkit.org/changeset/111361>
------- Comment #15 From 2012-03-19 22:59:03 PST -------
All reviewed patches have been landed.  Closing bug.
------- Comment #16 From 2012-03-20 10:12:21 PST -------
(In reply to comment #14)
> (From update of attachment 132752 [details] [details])
> Clearing flags on attachment: 132752
> 
> Committed r111361: <http://trac.webkit.org/changeset/111361>

It appears that you removed all the fast/frames/iframe-reparenting* tests except iframe-reparenting-unique-name.html. Was it intentional to leave that one in?
------- Comment #17 From 2012-03-20 10:44:21 PST -------
> Was it intentional to leave that one in?

Yeah, that test still seems to make sense without the feature.