Bug 81582 - [GTK] libWebCore.la has become too big for make
Summary: [GTK] libWebCore.la has become too big for make
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gustavo Noronha (kov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-19 16:08 PDT by Gustavo Noronha (kov)
Modified: 2012-03-27 11:32 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.73 KB, patch)
2012-03-19 16:13 PDT, Gustavo Noronha (kov) 		no flags Details | Formatted Diff | Diff
Patch (5.26 KB, patch)
2012-03-19 16:52 PDT, Gustavo Noronha (kov) 		no flags Details | Formatted Diff | Diff
Patch (7.43 KB, patch)
2012-03-19 19:08 PDT, Gustavo Noronha (kov) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2012-03-19 16:08:58 PDT 
[GTK] libWebCore.la has become too big for make
Comment 1 Gustavo Noronha (kov) 2012-03-19 16:13:02 PDT 
Created attachment 132701 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2012-03-19 16:19:52 PDT 
For reference: http://webkit-commit-queue.appspot.com/results/11986485
Comment 3 Gustavo Noronha (kov) 2012-03-19 16:32:46 PDT 
Comment on attachment 132701 [details]
Patch

Attachment 132701 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11984850
Comment 4 Gustavo Noronha (kov) 2012-03-19 16:52:50 PDT 
Created attachment 132718 [details]
Patch
Comment 5 Gustavo Noronha (kov) 2012-03-19 19:08:19 PDT 
Created attachment 132743 [details]
Patch
Comment 6 Gustavo Noronha (kov) 2012-03-19 20:22:47 PDT 
Comment on attachment 132743 [details]
Patch

Clearing flags on attachment: 132743

Committed r111340: <http://trac.webkit.org/changeset/111340>
Comment 7 Gustavo Noronha (kov) 2012-03-19 20:22:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Martin Robinson 2012-03-24 08:52:01 PDT 
Was this the "argument list too long" error?
Comment 9 Gustavo Noronha (kov) 2012-03-27 11:23:19 PDT 
Yes, it was. This was a quick fix to get the bots going, but I'm afraid we'll have to strive in keeping the argument list small for people building tarballs, in any case. Hopefully the recent trend towards breaking up WebCore continues.
Comment 10 Martin Robinson 2012-03-27 11:26:47 PDT 
(In reply to comment #9)
> Yes, it was. This was a quick fix to get the bots going, but I'm afraid we'll have to strive in keeping the argument list small for people building tarballs, in any case. Hopefully the recent trend towards breaking up WebCore continues.

The main issue is that it really slows down the linking phase.
Comment 11 Gustavo Noronha (kov) 2012-03-27 11:32:13 PDT 
I don't see many ways out. Perhaps have different intermediate libraries for bot builds and regular builds somehow? That may bring complexity up to untractable levels =(