Bug 81572 - Add FractionalLayoutUnit version of blend to AnimationUtilities
Summary: Add FractionalLayoutUnit version of blend to AnimationUtilities
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency tree / graph
 
Reported: 2012-03-19 15:31 PDT by Emil A Eklund
Modified: 2012-03-19 23:18 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.60 KB, patch)
2012-03-19 15:41 PDT, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Patch for landing (2.10 KB, patch)
2012-03-19 16:21 PDT, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-03-19 15:31:14 PDT 
Add version of blend that takes FractionalLayoutUnits.
Comment 1 Emil A Eklund 2012-03-19 15:41:39 PDT 
Created attachment 132689 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-03-19 15:43:46 PDT 
Comment on attachment 132689 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132689&action=review

rs=me.

> Source/WebCore/ChangeLog:9
> +        will be used in place of the integear version in many places once we

integear!
Comment 3 Gustavo Noronha (kov) 2012-03-19 15:48:53 PDT 
Comment on attachment 132689 [details]
Patch

Attachment 132689 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11988468
Comment 4 Emil A Eklund 2012-03-19 15:50:38 PDT 
(In reply to comment #2)
> (From update of attachment 132689 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=132689&action=review
> 
> rs=me.
> 
> > Source/WebCore/ChangeLog:9
> > +        will be used in place of the integear version in many places once we
> 
> integear!

argh, good catch.
Comment 5 Emil A Eklund 2012-03-19 16:21:41 PDT 
Created attachment 132706 [details]
Patch for landing

Added math.h include to FractionalLayoutUnit.h, should make the gtk bot happy. If it does I'll set cq+.
Comment 6 WebKit Review Bot 2012-03-19 23:17:41 PDT 
Comment on attachment 132706 [details]
Patch for landing

Clearing flags on attachment: 132706

Committed r111362: <http://trac.webkit.org/changeset/111362>
Comment 7 WebKit Review Bot 2012-03-19 23:17:45 PDT 
All reviewed patches have been landed.  Closing bug.