WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
8156
FrameMac::submitForm is busted after Vector changes
https://bugs.webkit.org/show_bug.cgi?id=8156
Summary
FrameMac::submitForm is busted after Vector changes
Eric Seidel (no email)
Reported
2006-04-03 09:27:14 PDT
I made some changes a while back to how form submission worked, and I busted FrameMac::submitForm. Strangely enough, no one has seemed to notice. However, WebKit is no longer seeing any form submission data, like it used to. This call: if (!request.doPost()) { [_bridge loadURL:request.url().getNSURL() referrer:[_bridge referrer] reload:request.reload userGesture:true target:request.frameName triggeringEvent:_currentEvent form:_formAboutToBeSubmitted formValues:_formValuesAboutToBeSubmitted]; _formAboutToBeSubmitted and _formValuesAboutToBeSubmitted are always nil. Those values are now held down on Frame, and just need to be converted from WebCore types into NS types and sent up to WebKit. It's simple to fix. I'm filing this bug so I don't forget. Maybe somone who knows more about that code path can comment as to why no one has noticed this being broken. Maybe WebKit no longer needs to know about form submission data (unless it's for autofill?)
Attachments
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2006-04-03 21:10:59 PDT
Yes, it's primarily for auto-fill.
Adele Peterson
Comment 2
2006-04-12 10:50:16 PDT
I have a patch to fix this.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug