Bug 8156 - FrameMac::submitForm is busted after Vector changes
Summary: FrameMac::submitForm is busted after Vector changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Adele Peterson
URL:
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2006-04-03 09:27 PDT by Eric Seidel (no email)
Modified: 2006-04-12 18:49 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2006-04-03 09:27:14 PDT 
I made some changes a while back to how form submission worked, and I busted FrameMac::submitForm.  Strangely enough, no one has seemed to notice.  However, WebKit is no longer seeing any form submission data, like it used to.

This call:

    if (!request.doPost()) {
        [_bridge loadURL:request.url().getNSURL()
                referrer:[_bridge referrer] 
                  reload:request.reload
             userGesture:true
                  target:request.frameName
         triggeringEvent:_currentEvent
                    form:_formAboutToBeSubmitted
              formValues:_formValuesAboutToBeSubmitted];

_formAboutToBeSubmitted
and
_formValuesAboutToBeSubmitted
are always nil.

Those values are now held down on Frame, and just need to be converted from WebCore types into NS types and sent up to WebKit.  It's simple to fix.  I'm filing this bug so I don't forget.

Maybe somone who knows more about that code path can comment as to why no one has noticed this being broken.  Maybe WebKit no longer needs to know about form submission data (unless it's for autofill?)
Comment 1 Darin Adler 2006-04-03 21:10:59 PDT 
Yes, it's primarily for auto-fill.
Comment 2 Adele Peterson 2006-04-12 10:50:16 PDT 
I have a patch to fix this.