RESOLVED FIXED 81553
[New Multicolumn] Stub out new classes to represent the region boxes for columns. 
https://bugs.webkit.org/show_bug.cgi?id=81553
Summary [New Multicolumn] Stub out new classes to represent the region boxes for colu...
Dave Hyatt
Reported 2012-03-19 13:37:21 PDT
Stub out new classes to represent the region boxes for columns.
Attachments
Patch (23.98 KB, patch)
2012-03-19 13:40 PDT, Dave Hyatt 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2012-03-19 13:40:49 PDT
Created attachment 132653 [details] Patch
WebKit Review Bot
Comment 2 2012-03-19 13:43:17 PDT
Attachment 132653 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/rendering/RenderRegionSet.h:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 3 2012-03-19 13:51:33 PDT
Comment on attachment 132653 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132653&action=review > Source/WebCore/rendering/RenderMultiColumnSet.h:35 > +// object, we significantly reduce the # of unique RenderObjects required to represent columns. Spell out “number”? > Source/WebCore/rendering/RenderRegionSet.h:40 > +// By combining runs of same-size columns or pages into a single object, we significantly reduce the # of unique RenderObjects Ditto.
Dave Hyatt
Comment 4 2012-03-19 13:59:24 PDT
Fix landed in r111240.
Note You need to log in before you can comment on or make changes to this bug.