Bug 81548 - Move the extra logical height distribution into RenderTable as a new step in our layout algorithm
Summary: Move the extra logical height distribution into RenderTable as a new step in ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tables (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-19 13:13 PDT by Julien Chaffraix
Modified: 2012-03-19 21:53 PDT (History)
3 users (show)

See Also:


Attachments
Proposed refactoring 1. (7.45 KB, patch)
2012-03-19 13:40 PDT, Julien Chaffraix
no flags Details | Formatted Diff | Diff
For win EWS testing. (7.41 KB, patch)
2012-03-19 16:19 PDT, Julien Chaffraix
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2012-03-19 13:13:32 PDT
This refactoring is needed to be able to implement a better distribution algorithm that would properly handle several sections.

Patch forthcoming.
Comment 1 Julien Chaffraix 2012-03-19 13:40:55 PDT
Created attachment 132654 [details]
Proposed refactoring 1.
Comment 2 Tony Chang 2012-03-19 14:16:10 PDT
Comment on attachment 132654 [details]
Proposed refactoring 1.

Seems reasonable.
Comment 3 Build Bot 2012-03-19 15:29:13 PDT
Comment on attachment 132654 [details]
Proposed refactoring 1.

Attachment 132654 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/11990028
Comment 4 Julien Chaffraix 2012-03-19 16:03:46 PDT
Comment on attachment 132654 [details]
Proposed refactoring 1.

View in context: https://bugs.webkit.org/attachment.cgi?id=132654&action=review

> Source/WebCore/rendering/RenderTable.cpp:307
> +    for (RenderTableSection* section = topSection(); section; section = sectionBelow(section)) {

Windows complains rightly here that we will never reach some of the statements. I will fix that and re-upload to see if it helps with the Win EWS.
Comment 5 Julien Chaffraix 2012-03-19 16:19:58 PDT
Created attachment 132703 [details]
For win EWS testing.
Comment 6 Julien Chaffraix 2012-03-19 20:58:15 PDT
Comment on attachment 132703 [details]
For win EWS testing.

It did the trick.
Comment 7 WebKit Review Bot 2012-03-19 21:53:34 PDT
Comment on attachment 132703 [details]
For win EWS testing.

Clearing flags on attachment: 132703

Committed r111353: <http://trac.webkit.org/changeset/111353>
Comment 8 WebKit Review Bot 2012-03-19 21:53:43 PDT
All reviewed patches have been landed.  Closing bug.