Bug 81541 – Move webaudio to Modules/webaudio/

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Mark Pilgrim (Google)]

Move webaudio to Modules/webaudio/

[Mark Pilgrim (Google)]

Created attachment 132633 [details]
Patch

[Build Bot]

Comment on attachment 132633 [details]
Patch

Attachment 132633 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/11986351

[WebKit Review Bot]

Comment on attachment 132633 [details]
Patch

Attachment 132633 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11985547

[Mark Pilgrim (Google)]

Created attachment 132637 [details]
Patch

[WebKit Review Bot]

Comment on attachment 132637 [details]
Patch

Attachment 132637 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11984693

[Build Bot]

Comment on attachment 132637 [details]
Patch

Attachment 132637 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/11982891

[Mark Pilgrim (Google)]

Created attachment 132661 [details]
Patch

[Adam Barth]

Comment on attachment 132661 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132661&action=review

This patch looks great, assuming it builds everywhere.

> Source/WebCore/CMakeLists.txt:379
> +    Modules/webaudio/AudioBuffer.idl

We should move these to be alphabetical.  (We can do that in a followup patch if you like.)

[Adam Barth]

Looks like your patch doesn't apply to TOT.

[Adam Barth]

Comment on attachment 132661 [details]
Patch

This looks good, but the patch doesn't apply to top-of-tree, so it's not getting run through the EWS bots.

[Mark Pilgrim (Google)]

Created attachment 132891 [details]
Patch

[WebKit Review Bot]

Attachment 132891 [details] did not pass style-queue:

Source/WebCore/Modules/webaudio/AudioContext.cpp:60:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/Modules/webaudio/AudioContext.cpp:622:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webaudio/ConvolverNode.cpp:41:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webaudio/ConvolverNode.cpp:77:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webaudio/ConvolverNode.cpp:84:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webaudio/AudioNodeOutput.h:77:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webaudio/WaveShaperNode.cpp:29:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Source/WebCore/Modules/webaudio/AudioNodeInput.h:71:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webaudio/AudioContext.h:108:  The parameter name "ec" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webaudio/AudioContext.h:247:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webaudio/AudioContext.h:248:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webaudio/AudioContext.h:250:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webaudio/AudioContext.h:265:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webaudio/RealtimeAnalyserNode.cpp:67:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webaudio/AudioNode.cpp:318:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webaudio/AudioNode.cpp:319:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webaudio/AudioBuffer.h:70:  The parameter name "bus" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp:183:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webaudio/RealtimeAnalyser.h:47:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webaudio/AudioPannerNode.cpp:309:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h:72:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h:77:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webaudio/JavaScriptAudioNode.cpp:134:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webaudio/JavaScriptAudioNode.cpp:169:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webaudio/JavaScriptAudioNode.cpp:181:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webaudio/JavaScriptAudioNode.cpp:194:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp:80:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
p:165:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp:470:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webaudio/AudioNode.h:88:  The parameter name "refType" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webaudio/AudioNode.h:89:  The parameter name "refType" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/webaudio/AudioNode.h:91:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/webaudio/AudioNode.h:92:  The parameter name "refType" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 33 in 114 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kentaro Hara]

Comment on attachment 132891 [details]
Patch

All bots are green!

[Kentaro Hara]

Comment on attachment 132891 [details]
Patch

Clearing flags on attachment: 132891

Committed r111474: <http://trac.webkit.org/changeset/111474>

[Kentaro Hara]

All reviewed patches have been landed.  Closing bug.

[Kentaro Hara]

Committed manually to avoid style check errors. Thank you very much for the patch. Let's keep watching the tree.

[Mark Pilgrim (Google)]

(In reply to comment #8)
> (From update of attachment 132661 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=132661&action=review
> 
> This patch looks great, assuming it builds everywhere.
> 
> > Source/WebCore/CMakeLists.txt:379
> > +    Modules/webaudio/AudioBuffer.idl
> 
> We should move these to be alphabetical.  (We can do that in a followup patch if you like.)

Bug 81825.