Bug 81531 - [BlackBerry] Add new layout test for text match marker
Summary: [BlackBerry] Add new layout test for text match marker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-19 11:32 PDT by Andy Chen
Modified: 2012-03-19 15:03 PDT (History)
5 users (show)

See Also:


Attachments
patch (9.28 KB, patch)
2012-03-19 11:39 PDT, Andy Chen
rwlbuis: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
updated text-expectations for cr (10.04 KB, patch)
2012-03-19 13:17 PDT, Andy Chen
no flags Details | Formatted Diff | Diff
updated text-expectations for cr (10.06 KB, patch)
2012-03-19 13:24 PDT, Andy Chen
no flags Details | Formatted Diff | Diff
updated text-expectations for cr (10.06 KB, patch)
2012-03-19 13:30 PDT, Andy Chen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Chen 2012-03-19 11:32:00 PDT
- Need to add new test case for text match marker.
- Need to make LayoutTestControllerBlackBerry::findString point to BlackBerry port implementation.
Comment 1 Andy Chen 2012-03-19 11:39:48 PDT
Created attachment 132618 [details]
patch
Comment 2 Rob Buis 2012-03-19 11:45:04 PDT
Comment on attachment 132618 [details]
patch

LGTM.
Comment 3 WebKit Review Bot 2012-03-19 12:20:57 PDT
Comment on attachment 132618 [details]
patch

Rejecting attachment 132618 [details] from commit-queue.

New failing tests:
platform/blackberry/editing/text-iterator/findString-markers.html
Full output: http://queues.webkit.org/results/11989249
Comment 4 Andy Chen 2012-03-19 12:25:56 PDT
(In reply to comment #3)
> (From update of attachment 132618 [details])
> Rejecting attachment 132618 [details] from commit-queue.
> 
> New failing tests:
> platform/blackberry/editing/text-iterator/findString-markers.html
> Full output: http://queues.webkit.org/results/11989249

The output says nothing about my test case.
Comment 5 WebKit Review Bot 2012-03-19 12:40:38 PDT
Comment on attachment 132618 [details]
patch

Attachment 132618 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11981860

New failing tests:
platform/blackberry/editing/text-iterator/findString-markers.html
Comment 6 Andy Chen 2012-03-19 12:53:55 PDT
(In reply to comment #5)
> (From update of attachment 132618 [details])
> Attachment 132618 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/11981860
> 
> New failing tests:
> platform/blackberry/editing/text-iterator/findString-markers.html

It is a test for blackberry port only, cr-linux should not even test it.
Comment 7 Andy Chen 2012-03-19 13:17:21 PDT
Created attachment 132640 [details]
updated text-expectations for cr
Comment 8 WebKit Review Bot 2012-03-19 13:20:23 PDT
Attachment 132640 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/platform/chromium/test_expectations.txt:575:  Missing expectations WONTFIX SKIP : platform/blackberry/editing/text-iterator/findString-markers.html  [test/expectations] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Andy Chen 2012-03-19 13:24:48 PDT
Created attachment 132646 [details]
updated text-expectations for cr
Comment 10 WebKit Review Bot 2012-03-19 13:27:14 PDT
Attachment 132646 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/platform/chromium/test_expectations.txt:575:  Missing expectations WONTFIX SKIP : platform/blackberry/editing/text-iterator/findString-markers.html PASS TIMEOUT FAIL  [test/expectations] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 Andy Chen 2012-03-19 13:30:04 PDT
Created attachment 132647 [details]
updated text-expectations for cr
Comment 12 Rob Buis 2012-03-19 13:46:54 PDT
Comment on attachment 132647 [details]
updated text-expectations for cr

Seems no errors now, lets retry.
Comment 13 WebKit Review Bot 2012-03-19 15:03:35 PDT
Comment on attachment 132647 [details]
updated text-expectations for cr

Clearing flags on attachment: 132647

Committed r111256: <http://trac.webkit.org/changeset/111256>
Comment 14 WebKit Review Bot 2012-03-19 15:03:40 PDT
All reviewed patches have been landed.  Closing bug.