Bug 81530 – platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Jessie Berlin]

http://build.webkit.org/results/Lion%20Intel%20Debug%20(WebKit2%20Tests)/r111198%20(5036)/platform/mac/accessibility/selected-rows-table-pretty-diff.html

--- /Volumes/Data/slave/lion-intel-debug-tests-wk2/build/layout-test-results/platform/mac/accessibility/selected-rows-table-expected.txt
+++ /Volumes/Data/slave/lion-intel-debug-tests-wk2/build/layout-test-results/platform/mac/accessibility/selected-rows-table-actual.txt
@@ -11,8 +11,8 @@
 

 PASS addedNotification is true
-PASS axTree.selectedRowAtIndex(0).isEqual(axTree.rowAtIndex(0)) is true
-PASS axTree.selectedRowAtIndex(1).isEqual(axTree.rowAtIndex(2)) is true
+FAIL axTree.selectedRowAtIndex(0).isEqual(axTree.rowAtIndex(0)) should be true. Threw exception TypeError: 'undefined' is not a function (evaluating 'axTree.rowAtIndex(0)')
+FAIL axTree.selectedRowAtIndex(1).isEqual(axTree.rowAtIndex(2)) should be true. Threw exception TypeError: 'undefined' is not a function (evaluating 'axTree.rowAtIndex(2)')
 PASS successfullyParsed is true
 
 TEST COMPLETE

Unfortunately, due to the state of our tests, I don't know when this started.

[Radar WebKit Bug Importer]

<rdar://problem/11074696>

[Jessie Berlin]

Added expected failing results for mac-wk2 in http://trac.webkit.org/changeset/111210

[chris fleizach]

might be that i forgot to add this method to WK test runner

[Jessie Berlin]

(In reply to comment #3)
> might be that i forgot to add this method to WK test runner

Yes, "rowAtIndex" appears to be missing from AccessibilityUIElement.h in WebKitTestRunner's project.

[chris fleizach]

Created attachment 132642 [details]
patch

[Jessie Berlin]

Comment on attachment 132642 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132642&action=review

r=me!

> Tools/ChangeLog:8
> +        At rowAtIndex to WebKitTestRunner

Typo: "At" instead of "Add".
Nit pick: Please end with a period.

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:341
> +

Nit pick: please remove this extra line.

[chris fleizach]

http://trac.webkit.org/changeset/111233