Bug 81512 - [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
Summary: [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sudarsana Nagineni (babu)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-19 08:46 PDT by Sudarsana Nagineni (babu)
Modified: 2012-05-15 00:20 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.02 KB, patch)
2012-03-19 09:14 PDT, Sudarsana Nagineni (babu) 		no flags Details | Formatted Diff | Diff
patch (6.01 KB, patch)
2012-03-19 09:24 PDT, Sudarsana Nagineni (babu) 		no flags Details | Formatted Diff | Diff
Patch (6.01 KB, patch)
2012-03-20 04:28 PDT, Sudarsana Nagineni (babu) 		no flags Details | Formatted Diff | Diff
Patch (6.20 KB, patch)
2012-03-22 09:58 PDT, Sudarsana Nagineni (babu) 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sudarsana Nagineni (babu) 2012-03-19 08:46:44 PDT 
Add markerTextForListItem() to EFL's LayoutTestController and enable related tests.
Comment 1 Sudarsana Nagineni (babu) 2012-03-19 09:14:15 PDT 
Created attachment 132595 [details]
Patch

Implement markerTextForListItem and enable tests.
Comment 2 WebKit Review Bot 2012-03-19 09:19:13 PDT 
Attachment 132595 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
Source/WebKit/efl/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h:84:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sudarsana Nagineni (babu) 2012-03-19 09:24:57 PDT 
Created attachment 132596 [details]
patch

fix style check errors
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-03-19 09:31:51 PDT 
Comment on attachment 132596 [details]
patch

Thanks for the patch. It looks OK, but I'd rather return a String in DRTSupportEfl::markerTextForListItem() and then do the String->CString->char* conversion in LTC::markerTextForListItem() instead, as in general we work and pass String's around.
Comment 5 Sudarsana Nagineni (babu) 2012-03-20 04:28:31 PDT 
Created attachment 132798 [details]
Patch

Fix review comment #4
Comment 6 Raphael Kubo da Costa (:rakuco) 2012-03-20 06:19:01 PDT 
Comment on attachment 132798 [details]
Patch

Looks good, thank you.
Comment 7 Sudarsana Nagineni (babu) 2012-03-22 09:58:35 PDT 
Created attachment 133284 [details]
Patch

rebased
Comment 8 WebKit Review Bot 2012-03-22 13:52:04 PDT 
Comment on attachment 133284 [details]
Patch

Clearing flags on attachment: 133284

Committed r111756: <http://trac.webkit.org/changeset/111756>
Comment 9 WebKit Review Bot 2012-03-22 13:52:09 PDT 
All reviewed patches have been landed.  Closing bug.