Bug 81492 – Use CSSPrimitiveValue::convertToLength() in a few places.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Luke Macpherson]

Use CSSPrimitiveValue::convertToLength() in a few places.

[Luke Macpherson]

Created attachment 132546 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 132546 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132546&action=review

OK.  These template functions seem slightly awkward to use.  I could easily imagine missing one of the OR bits I should have when writing new code. :(

> Source/WebCore/css/CSSStyleApplyProperty.cpp:1568
> +        selector->style()->setVerticalAlignLength(primitiveValue->convertToLength<FixedIntegerConversion | PercentConversion>(selector->style(), selector->rootElementStyle(), selector->style()->effectiveZoom()));

I think having a Length local might help readability here. :)

[Luke Macpherson]

Created attachment 132949 [details]
Patch

[WebKit Review Bot]

Attachment 132949 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/CSSPrimitiveValueMappings.h:34:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Luke Macpherson]

Comment on attachment 132949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132949&action=review

>> Source/WebCore/css/CSSPrimitiveValueMappings.h:34
>> +#include "CSSCalculationValue.h"
> 
> Alphabetical sorting problem.  [build/include_order] [4]

It lies!

[Simon Fraser (smfr)]

Comment on attachment 132949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132949&action=review

> Source/WebCore/ChangeLog:8
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        No new tests - refactoring only.

Why no description of changes? You at least need to justify the refactoring.

[Eric Seidel (no email)]

Comment on attachment 132949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132949&action=review

Seems reasonable.

>>> Source/WebCore/css/CSSPrimitiveValueMappings.h:34
>>> +#include "CSSCalculationValue.h"
>> 
>> Alphabetical sorting problem.  [build/include_order] [4]
> 
> It lies!

It thinks ColorSpace should be after CSS.  the capital S is before all lower case letters, I believe.

[Luke Macpherson]

Created attachment 133146 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 133146 [details]
Patch for landing

Clearing flags on attachment: 133146

Committed r111631: <http://trac.webkit.org/changeset/111631>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.