Bug 81467 – webkitpy: Make FreeBSD be recognized as a valid platform.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Raphael Kubo da Costa (:rakuco)]

webkitpy: Make FreeBSD be recognized as a valid platform.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 132484 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 132484 [details]
Patch

Oh boy.  I think you just want to pretend to be linux...  Maybe not... but this just seems like signing up for a world of pain.

[Raphael Kubo da Costa (:rakuco)]

I'm all ears to suggestions. If just pretending to be Linux in platforminfo.py is better, I'm fine with that. Can't think of a better solution for the other files, though.

[Eric Seidel (no email)]

Theoretically more of webkitpy should depend on PlatformInfo, instead of grabbing at sys.platform directly.  But I'll look at this tomorrow when I'm more awake. :)  Your patch is probably fine...

[Adam Barth]

Which WebKit ports run on FreeBSD?

[Raphael Kubo da Costa (:rakuco)]

(In reply to comment #5)
> Which WebKit ports run on FreeBSD?

The EFL one, and probably the GTK+ and Qt ones as well (I haven't built them in a while, but stable versions of these ports are regularly packaged). Chrome is also packaged, so I guess the chromium port also runs on FreeBSD, and, if it doesn't have any exotic dependencies, so does the wx port.

[Adam Barth]

Comment on attachment 132484 [details]
Patch

I'm inclined to mark this patch R- unless/until you plan to run FreeBSD-based bots on build.webkit.org.  As far as I know, there are no such bots and I haven't heard that anyone plans to add one.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 140141 [details]
Second attempt with a smaller patch

[Raphael Kubo da Costa (:rakuco)]

With dpranke's help, I've been committing some changes which have helped make this patch smaller. The current sys.platform and PlatformInfo.is_foo() checks in webkitpy are for Windows-only code, so supporting FreeBSD is mostly a matter of adding is_freebsd() to PlatformInfo.

As for a build bot, dpranke and I talked about it on IRC today, and it's mostly a matter of having some spare CPU cycles for that (as an individual developer I don't have a machine for that) and we'll try to get one.

[Dirk Pranke]

Comment on attachment 140141 [details]
Second attempt with a smaller patch

The patch looks fine to me. Adam, I think it's reasonable to land this given that it's basically one if-statement and a bunch of unit tests. The maintenance needs for bsd should be pretty low. On a related note, I think I will ping a few people to see if they want to pony up to support at least a minimal BSD bot. I know we had a chromium port to BSD at some point (e.g., for the capsicum work) and so someone might be interested in keeping it going.

[Adam Barth]

Comment on attachment 140141 [details]
Second attempt with a smaller patch

Yep, agreed.

[Raphael Kubo da Costa (:rakuco)]

Committed r116061: <http://trac.webkit.org/changeset/116061>

[Eric Seidel (no email)]

Comment on attachment 140141 [details]
Second attempt with a smaller patch

OK.  I guess we'll end up using this check more places? I'm still surprised that freebsd wants to be different from linux (I understand that they can be quite different, having worked on Apple's BSD team, but I'm surprised that webkitpy would need to know much about those differences.)

[Raphael Kubo da Costa (:rakuco)]

In practice, right now there is no difference between linux and freebsd for webkitpy. abarth, dprank and I talked about just lying that freebsd is linux in PlatformInfo.is_linux() in March, and at the time Dirk felt "a little leery" about that. We then discussed adding is_unix() (or some thing like that) to PlatformInfo, but that has not been done yet (99% percent of the calls are for is_mac() and is_win() anyway).

[Dirk Pranke]

(In reply to comment #13)
> (From update of attachment 140141 [details])
> OK.  I guess we'll end up using this check more places? I'm still surprised that freebsd wants to be different from linux (I understand that they can be quite different, having worked on Apple's BSD team, but I'm surprised that webkitpy would need to know much about those differences.)

At the moment, is_linux() and is_freebsd() are both only used in one place (and it's the same place, to determine the default port to use in PortFactory() if not win/mac.