RESOLVED FIXED 81445
Simplify SmallStrings 
https://bugs.webkit.org/show_bug.cgi?id=81445
Summary Simplify SmallStrings
Benjamin Poulain
Reported 2012-03-16 23:19:27 PDT
You might wonder why SmallStrings has a public clear() and count(), so do I.
Attachments
Patch (2.98 KB, patch)
2012-03-16 23:26 PDT, Benjamin Poulain 		barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2012-03-16 23:26:13 PDT
Created attachment 132449 [details] Patch
Benjamin Poulain
Comment 2 2012-03-19 19:11:42 PDT
Committed r111306: <http://trac.webkit.org/changeset/111306>
Darin Adler
Comment 3 2012-03-23 09:04:40 PDT
Comment on attachment 132449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132449&action=review > Source/JavaScriptCore/runtime/SmallStrings.cpp:74 > + m_emptyString = 0; Would be even better to use an initializer for this instead of assignment in the body of the function.
Benjamin Poulain
Comment 4 2012-03-23 11:51:01 PDT
> > Source/JavaScriptCore/runtime/SmallStrings.cpp:74 > > + m_emptyString = 0; > > Would be even better to use an initializer for this instead of assignment in the body of the function. This was the first of a pair of patch. The second actually did that, so no worries :)
Note You need to log in before you can comment on or make changes to this bug.