extract logic of idb tests
Created attachment 132434 [details] Patch
not ready for review yet, just FYI
Created attachment 133399 [details] Patch
Created attachment 133549 [details] Patch
Created attachment 133551 [details] Patch
Comment on attachment 133551 [details] Patch Josh, this is ready for a look.
Comment on attachment 133551 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133551&action=review > LayoutTests/ChangeLog:14 > + The first three simulate mouse events and the last isn't really a test. structured-clone.html uses mouse events too (to create File/FileList objects, although those tests are currently disabled). Should it be skipped too? That test also uses a few more things like ImageData that workers won't be able to create. We may want to split that test up or make it validate both window and worker cases, passing the cloned values to the worker. (values-odd-types.html does similar work, but is probably a redundant subset now) > LayoutTests/storage/indexeddb/createObjectStore-name-argument-required.html:-1 > -<!DOCTYPE html> Just removing the DOCTYPE preamble for consistency? In IE this is used to trigger "standards mode", I don't know if WebKit actually does anything with it. It shouldn't matter either way for the test. It's strictly required by the HTML5 spec, though - http://dev.w3.org/html5/spec/single-page.html#syntax-doctype > LayoutTests/storage/indexeddb/list-ordering.html:-7 > -<input type="file" id="fileInput" multiple></input> Oops, thanks for deleting this.
... and otherwise lgtm
(In reply to comment #7) > (From update of attachment 133551 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=133551&action=review > > > LayoutTests/ChangeLog:14 > > + The first three simulate mouse events and the last isn't really a test. > > structured-clone.html uses mouse events too (to create File/FileList objects, although those tests are currently disabled). Should it be skipped too? > > That test also uses a few more things like ImageData that workers won't be able to create. We may want to split that test up or make it validate both window and worker cases, passing the cloned values to the worker. (values-odd-types.html does similar work, but is probably a redundant subset now) Structured cloning on workers seems ripe for corner cases so I want to do one of your suggestions, or something intelligent, but will skip it for now. > > LayoutTests/storage/indexeddb/createObjectStore-name-argument-required.html:-1 > > -<!DOCTYPE html> > > Just removing the DOCTYPE preamble for consistency? Just for consistency. All the html files were generated from a single template. In IE this is used to trigger "standards mode", I don't know if WebKit actually does anything with it. It shouldn't matter either way for the test. It's strictly required by the HTML5 spec, though - http://dev.w3.org/html5/spec/single-page.html#syntax-doctype > > > LayoutTests/storage/indexeddb/list-ordering.html:-7 > > -<input type="file" id="fileInput" multiple></input> > > Oops, thanks for deleting this.
Created attachment 133576 [details] Patch
Tony, could you review this? I'm not sure why win-ews can't apply the patch. win_layout_rel applied it without problems. http://build.chromium.org/p/tryserver.chromium/builders/win_layout_rel/builds/152/steps/update/logs/stdio
Comment on attachment 133576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133576&action=review rs=me > LayoutTests/ChangeLog:29 > + * storage/indexeddb/constants.html: > + * storage/indexeddb/create-and-remove-object-store.html: > + * storage/indexeddb/create-object-store-options.html: > + * storage/indexeddb/createObjectStore-name-argument-required.html: > + * storage/indexeddb/createObjectStore-null-name.html: > + * storage/indexeddb/cursor-continue.html: > + * storage/indexeddb/cursor-delete.html: It's OK to trim this. You could just list the important files (e.g., the two -expected.txt files where line numbers changed).
Created attachment 133907 [details] Patch for landing
Attachment 133907 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/stor..." exit_code: 1 LayoutTests/ChangeLog:26: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 245 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 133907 [details] Patch for landing Rejecting attachment 133907 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12148089
Created attachment 133931 [details] Patch for landing
Comment on attachment 133931 [details] Patch for landing Clearing flags on attachment: 133931 Committed r112202: <http://trac.webkit.org/changeset/112202>
All reviewed patches have been landed. Closing bug.