Bug 81438 – Add support for crossorigin attribute in script elements

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Pablo Flouret]

Basically mirror img's crossorigin attribute behavior for script.

Gecko added it recently https://bugzilla.mozilla.org/show_bug.cgi?id=696301

Mail went out to the whatwg with no response so far, http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-February/034969.html
I'll bump the thread to see if anyone has any thoughts.

[Pablo Flouret]

Created attachment 132433 [details]
Patch

[Adam Barth]

Comment on attachment 132433 [details]
Patch

I took a quick look and this looks pretty good.  I'll look in more detail later if no one beats me to the punch.

[Gyuyoung Kim]

Comment on attachment 132433 [details]
Patch

Attachment 132433 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/11974258

[Adam Barth]

Comment on attachment 132433 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132433&action=review

> Source/WebCore/dom/ScriptElement.cpp:320
> +    if (m_element->fastHasAttribute(HTMLNames::crossoriginAttr)

So, this isn't 100% correct.  We should lock in the notion of whether this is a crossorigin load when the load is initiated.  By re-checking the attribute here, we might get a different value the second time.  That's an extremely minor bug though.

[Adam Barth]

(Obviously, we should address the EFL failure before landing this patch.)

[Pablo Flouret]

(In reply to comment #4)
> (From update of attachment 132433 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=132433&action=review
> 
> > Source/WebCore/dom/ScriptElement.cpp:320
> > +    if (m_element->fastHasAttribute(HTMLNames::crossoriginAttr)
> 
> So, this isn't 100% correct.  We should lock in the notion of whether this is a crossorigin load when the load is initiated.  By re-checking the attribute here, we might get a different value the second time.  That's an extremely minor bug though.

Yeah, good catch. ImageLoader::notifyFinished() should probably be fixed as well (although the code there doesn't really prevent the image from loading at the moment, i guess there's bug 80028 for that).

(In reply to comment #5)
> (Obviously, we should address the EFL failure before landing this patch.)

EFL woes look unrelated, i'll upload a new patch and see if ews comes to the rescue.

[Pablo Flouret]

Created attachment 132674 [details]
Patch for landing

[Adam Barth]

Comment on attachment 132674 [details]
Patch for landing

I'm tired of waiting for the efl-ews.  I think you're right that the failure wasn't caused by your patch.

[WebKit Review Bot]

Comment on attachment 132674 [details]
Patch for landing

Clearing flags on attachment: 132674

Committed r111359: <http://trac.webkit.org/changeset/111359>

[Darin Fisher (:fishd, Google)]

Looks like this bug can be closed.