Bug 81411 - Add a land-from-url command
Summary: Add a land-from-url command
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-16 14:51 PDT by Eric Seidel (no email)
Modified: 2012-03-19 00:21 PDT (History)
4 users (show)

See Also:


Attachments
Patch (9.24 KB, patch)
2012-03-16 14:52 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-03-16 14:51:33 PDT
Add a land-from-url command
Comment 1 Eric Seidel (no email) 2012-03-16 14:52:49 PDT
Created attachment 132387 [details]
Patch
Comment 2 Adam Barth 2012-03-16 14:58:21 PDT
Comment on attachment 132387 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132387&action=review

> Tools/Scripts/webkitpy/tool/commands/download.py:213
> +            bug_id = urls.parse_bug_id(url)
> +            if bug_id:
> +                patches = tool.bugs.fetch_bug(bug_id).patches()
> +                log("%s found on bug %s." % (pluralize("patch", len(patches)), bug_id))
> +                all_patches += patches

It's a bit odd that this works differently than land-from-bug.  In person you gave me a big speech about how land-from-bug is confusing and wrong, so I guess that means you plan to fix land-from-bug?  ;)
Comment 3 WebKit Review Bot 2012-03-16 17:19:26 PDT
Comment on attachment 132387 [details]
Patch

Clearing flags on attachment: 132387

Committed r111095: <http://trac.webkit.org/changeset/111095>
Comment 4 WebKit Review Bot 2012-03-16 17:19:31 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Dirk Pranke 2012-03-16 17:32:15 PDT
For those of us not there in person ... what is the point of this command? "land all the patches at a given URL" sounds dodgy on the face of it.
Comment 6 Adam Barth 2012-03-16 17:40:09 PDT
(In reply to comment #5)
> For those of us not there in person ... what is the point of this command? "land all the patches at a given URL" sounds dodgy on the face of it.

Any more dodgy than the land-from-bug command?  We want to be able to accept patches from various sources besides just bugs and attachments (e.g., libpaste, GitHub).  A URL is a nice universal designator.

The plan is to whitelist the sources, at least at first.  Notice that this command only currently accepts bugs.webkit.org URLs.
Comment 7 Dirk Pranke 2012-03-16 17:46:04 PDT
(In reply to comment #6)
> (In reply to comment #5)
> > For those of us not there in person ... what is the point of this command? "land all the patches at a given URL" sounds dodgy on the face of it.
> 
> Any more dodgy than the land-from-bug command? 

Sure; land-from-bug at least sounds like you're poking at a structured, approved place.

At any rate, I have no objection to landing patches retrieved from arbitrary URLs (since presumably you know that the url is a patch), but I wasn't sure if you were planning to scrape pages looking for embedded links to patches, or what, that's all. Just looking to understand what you have in mind ...
Comment 8 Adam Barth 2012-03-16 18:34:50 PDT
We also have a dream of having sheriffbot land patches (e.g., specified by URL).  There's some trickiness around authentication, of course.
Comment 9 Dirk Pranke 2012-03-16 20:04:05 PDT
(In reply to comment #8)
> We also have a dream of having sheriffbot land patches (e.g., specified by URL).

When would you want to do this and not just use the CQ?
Comment 10 Adam Barth 2012-03-19 00:21:54 PDT
> When would you want to do this and not just use the CQ?

For example, if you have rollout that you want to land right now (and don't want to wait for the CQ), or if you have a patch that just changes the web site and you don't want to wait for building/running the tests.