[chromium] Tune fling physics curve. [Not for review yet]
Created attachment 132364 [details] Patch
Attachment 132364 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Curve mod proposal #1: just increase initial run-out time. Feel free to play with the parameter ... this patch will break unit tests but please ignore for now. I'll post an alternative shortly, based on a pseudo-parabolic curve.
Created attachment 132381 [details] Patch
Comment on attachment 132381 [details] Patch This curve profile has ramp-up shown in attached PDF file.
Created attachment 132382 [details] Velocity profile Velocity profile for curve in second patch.
Attachment 132381 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/TouchFlingPlatformGestureCurve.cpp:66: Missing spaces around / [whitespace/operators] [3] Source/WebCore/platform/TouchFlingPlatformGestureCurve.cpp:72: Missing spaces around / [whitespace/operators] [3] Source/WebCore/platform/TouchFlingPlatformGestureCurve.cpp:74: Missing spaces around / [whitespace/operators] [3] Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 132413 [details] Patch
Attachment 132413 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/TouchFlingPlatformGestureCurve.cpp:66: Missing spaces around / [whitespace/operators] [3] Source/WebCore/platform/TouchFlingPlatformGestureCurve.cpp:72: Missing spaces around / [whitespace/operators] [3] Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
it feels pretty right to me.
Comment on attachment 132413 [details] Patch Attachment 132413 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/11967545
Created attachment 132605 [details] Patch
Created attachment 132610 [details] Patch
Fixed issue with time scale factor.
I've tried it out and shown to anicolao. It seems like enough of an improvement that it's worth landing.
Comment on attachment 132610 [details] Patch If we're using this for wheel flings can we call it the right thing, or alternately make this curve be the WheelFlingPlatformGestureCurve?
(In reply to comment #16) > (From update of attachment 132610 [details]) > If we're using this for wheel flings can we call it the right thing, or alternately make this curve be the WheelFlingPlatformGestureCurve? Shouldn't this be a TrackPadFlingPlatformGestureCurve? An actual physical wheel should have something much more like the WheelFlingPlatformGestureCurve implementation.
Sure, that might be an even better name. The more explicit the better, IMO.
Comment on attachment 132610 [details] Patch Looks fine. Please rename soon if you get a chance so this is less confusing to read.
Comment on attachment 132610 [details] Patch Clearing flags on attachment: 132610 Committed r111395: <http://trac.webkit.org/changeset/111395>
All reviewed patches have been landed. Closing bug.
(In reply to comment #19) > (From update of attachment 132610 [details]) > Looks fine. Please rename soon if you get a chance so this is less confusing to read. Will upload re-naming patch by end of day.