Bug 81383 – [chromium] Adding support for GL_EXT_discard_framebuffer.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Michal Mocny]

[chromium] Adding support for GL_EXT_discard_framebuffer.

[Michal Mocny]

Created attachment 132338 [details]
Patch

[Michal Mocny]

Comment on attachment 132338 [details]
Patch

This is the other WebGraphicsContext3D extension needed for compositor memory allocation changed callback handler.  (The other is https://bugs.webkit.org/show_bug.cgi?id=81279)

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail] or [e-mail] before submitting because this patch contains changes to the Chromium platform API.

[Michal Mocny]

Comment on attachment 132338 [details]
Patch

This cl will change, as the extension is going to have some arguments to better mirror http://www.khronos.org/registry/gles/extensions/EXT/EXT_discard_framebuffer.txt

[Michal Mocny]

Created attachment 132587 [details]
Patch

[Michal Mocny]

Comment on attachment 132587 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132587&action=review

> Source/Platform/chromium/public/WebGraphicsContext3D.h:162
> +    virtual void ensureFramebufferCHROMIUM() { }

This is a chromium extension to the discard framebuffer extension which is very likely to be removed once we support the automatic recreation of backbuffer upon first use.
Due to the time pressure for getting this in, it is unlikely to happen before M19, hence this explicit call.

Is it alright to share the single "GL_EXT_discard_framebuffer" string, or shall I add a "GL_CHROMIUM_ensure_framebuffer"?

[Nat Duca]

Comment on attachment 132587 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132587&action=review

LGTM. @enne or @jamesr for review.

>> Source/Platform/chromium/public/WebGraphicsContext3D.h:162
>> +    virtual void ensureFramebufferCHROMIUM() { }
> 
> This is a chromium extension to the discard framebuffer extension which is very likely to be removed once we support the automatic recreation of backbuffer upon first use.
> Due to the time pressure for getting this in, it is unlikely to happen before M19, hence this explicit call.
> 
> Is it alright to share the single "GL_EXT_discard_framebuffer" string, or shall I add a "GL_CHROMIUM_ensure_framebuffer"?

Seems fine

[WebKit Review Bot]

Comment on attachment 132587 [details]
Patch

Clearing flags on attachment: 132587

Committed r111312: <http://trac.webkit.org/changeset/111312>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.