Bug 81373 - [BlackBerry] Implement openTemporaryFile in FileSystem
Summary: [BlackBerry] Implement openTemporaryFile in FileSystem
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-16 11:00 PDT by Rob Buis
Modified: 2012-03-19 07:24 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.36 KB, patch)
2012-03-16 11:10 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (3.39 KB, patch)
2012-03-16 12:22 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (3.55 KB, patch)
2012-03-16 15:27 PDT, Rob Buis 		staikos: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2012-03-16 11:00:56 PDT 
We currently lack an implementation:

String openTemporaryFile(const String&, PlatformFileHandle&)
{
    return "";
}
Comment 1 Rob Buis 2012-03-16 11:10:25 PDT 
Created attachment 132322 [details]
Patch
Comment 2 Rob Buis 2012-03-16 11:27:15 PDT 
I added the Efl folks on CC to make sure they would be ok with the change. I also wonder if I left out anybody from the posix group?
Comment 3 Rob Buis 2012-03-16 12:22:29 PDT 
Created attachment 132344 [details]
Patch
Comment 4 Rob Buis 2012-03-16 15:27:58 PDT 
Created attachment 132396 [details]
Patch
Comment 5 Rob Buis 2012-03-17 12:18:57 PDT 
The patch seems to work on the buildbots now :)
Comment 6 George Staikos 2012-03-17 12:39:44 PDT 
Comment on attachment 132396 [details]
Patch

Presuming that EFL builds the POSIX file, which it seems to based on the bots, this is good for me.  I wish the goto would go away though.
Comment 7 Rob Buis 2012-03-19 07:24:02 PDT 
Landed as r111127.