WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 81373
[BlackBerry] Implement openTemporaryFile in FileSystem
https://bugs.webkit.org/show_bug.cgi?id=81373
Summary
[BlackBerry] Implement openTemporaryFile in FileSystem
Rob Buis
Reported
2012-03-16 11:00:56 PDT
We currently lack an implementation: String openTemporaryFile(const String&, PlatformFileHandle&) { return ""; }
Attachments
Patch
(3.36 KB, patch)
2012-03-16 11:10 PDT
,
Rob Buis
no flags
Details
Formatted Diff
Diff
Patch
(3.39 KB, patch)
2012-03-16 12:22 PDT
,
Rob Buis
no flags
Details
Formatted Diff
Diff
Patch
(3.55 KB, patch)
2012-03-16 15:27 PDT
,
Rob Buis
staikos
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Rob Buis
Comment 1
2012-03-16 11:10:25 PDT
Created
attachment 132322
[details]
Patch
Rob Buis
Comment 2
2012-03-16 11:27:15 PDT
I added the Efl folks on CC to make sure they would be ok with the change. I also wonder if I left out anybody from the posix group?
Rob Buis
Comment 3
2012-03-16 12:22:29 PDT
Created
attachment 132344
[details]
Patch
Rob Buis
Comment 4
2012-03-16 15:27:58 PDT
Created
attachment 132396
[details]
Patch
Rob Buis
Comment 5
2012-03-17 12:18:57 PDT
The patch seems to work on the buildbots now :)
George Staikos
Comment 6
2012-03-17 12:39:44 PDT
Comment on
attachment 132396
[details]
Patch Presuming that EFL builds the POSIX file, which it seems to based on the bots, this is good for me. I wish the goto would go away though.
Rob Buis
Comment 7
2012-03-19 07:24:02 PDT
Landed as
r111127
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug