Bug 81370 - IndexedDB: LayoutTests don't need explicit console div
Summary: IndexedDB: LayoutTests don't need explicit console div
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P4 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-16 10:48 PDT by Joshua Bell
Modified: 2012-03-19 11:39 PDT (History)
3 users (show)

See Also:


Attachments
Patch (61.63 KB, patch)
2012-03-16 12:21 PDT, Joshua Bell
no flags Details | Formatted Diff | Diff
Patch for landing (85.89 KB, patch)
2012-03-19 10:59 PDT, Joshua Bell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-03-16 10:48:29 PDT
All of storage/indexeddb/*.html files include <div id="console"></div> - this is created on the fly by js-test-pre.js if necessary and can be removed from the HTML file.
Comment 1 Joshua Bell 2012-03-16 11:12:20 PDT
Ditto for <p id="description"></p>

Also, can remove explicit jsTestIsAsync = true, for scripts that include shared.js
Comment 2 Joshua Bell 2012-03-16 12:21:25 PDT
Created attachment 132342 [details]
Patch
Comment 3 Joshua Bell 2012-03-16 12:22:53 PDT
perl -pnie FTW.

The handful of *-expected.txt changes are for few blank lines that disappear, and line numbers for expected exceptions.
Comment 4 David Grogan 2012-03-16 12:24:29 PDT
LGTM
Comment 5 Tony Chang 2012-03-16 13:13:55 PDT
Comment on attachment 132342 [details]
Patch

rs=me
Comment 6 Joshua Bell 2012-03-19 10:59:27 PDT
Created attachment 132608 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-03-19 11:39:38 PDT
Comment on attachment 132608 [details]
Patch for landing

Clearing flags on attachment: 132608

Committed r111211: <http://trac.webkit.org/changeset/111211>
Comment 8 WebKit Review Bot 2012-03-19 11:39:43 PDT
All reviewed patches have been landed.  Closing bug.