Bug 8137 – REGRESSION: scrolling on Google maps continues after the mouse is released outside the window

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Alexey Proskuryakov]

The same problem as in bug 5923, but apparently with a different cause (as the layout test still passes).

Steps to reproduce:
1. Go to http://maps.google.com
2. Click the mouse anywhere on the map, drag until the mouse pointer goes
outside the Safari window
3. Release the mouse button
4. Move the mouse pointer back into the window

Results: the map scrolls, although the mouse button is not down
Expected results (as in Safari 2.0.3): it shouldn't

This time around the problem seems to be that the final mouseup event is not delivered, because of the mouseDown check in RenderLayer::shouldApplyImplicitCapture(), which was introduced in r13601.

[Darin Adler]

Maciej, your change log for r13601 says nothing about what you were trying to accomplish with that check-in, so I am not comfortable making a change. But it does seem clear that a mouse up event wants to participate in the capture even though the mouse is no longer down at the time it's generated.

[Darin Adler]

We'll need a test case, so attaching the NeedsReduction keyword.

[Alice Liu]

<rdar://problem/4549745>

[Joost de Valk (AlthA)]

Adding GoogleBug keyword in one big change.

[Alexey Proskuryakov]

(In reply to comment #1)
> This time around the problem seems to be that the final mouseup event is not
> delivered, because of the mouseDown check in
> RenderLayer::shouldApplyImplicitCapture(), which was introduced in r13601.

This method no longer exists due to refactoring, but the problem remains. I couldn't quickly find where this logic was moved.

(In reply to comment #6)
> (In reply to comment #1)
> This method no longer exists due to refactoring, but the problem remains. I
> couldn't quickly find where this logic was moved.
> 

Now in RenderLayer::hitTestLayer(), the request.active condition:

    // We didn't hit any layer.  However if the mouse is down, we must always at least be inside
    // the render view.
    if (request.active && renderer()->isRenderView()) {
        renderer()->setInnerNode(result);
        return this;
    }

[Geoffrey Garen]

I'm working on this.

[Geoffrey Garen]

Created attachment 11906 [details]
reduction

[Geoffrey Garen]

Created attachment 11910 [details]
reduction

New reduction. Mitz pointed out that the old reduction tested for behavior that, though different in shipping Safari, was incorrect.

[Geoffrey Garen]

Committed revision 18304.

(In reply to comment #11)
> Committed revision 18304.
> 

The patch caused bug 11880.