WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
81364
[BlackBerry] Input fields with id of e-mail and url should be styled as such.
https://bugs.webkit.org/show_bug.cgi?id=81364
Summary
[BlackBerry] Input fields with id of e-mail and url should be styled as such.
Mike Fenton
Reported
2012-03-16 10:08:07 PDT
For any input fields that are identified as email or url they should also use the appropriate style.
Attachments
Patch
(8.16 KB, patch)
2012-03-16 10:19 PDT
,
Mike Fenton
no flags
Details
Formatted Diff
Diff
Follow up patch
(2.99 KB, patch)
2012-03-16 13:12 PDT
,
Mike Fenton
rwlbuis
: review+
mifenton
: commit-queue-
Details
Formatted Diff
Diff
Proper follow up patch.
(2.95 KB, patch)
2012-03-16 13:17 PDT
,
Mike Fenton
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Mike Fenton
Comment 1
2012-03-16 10:19:02 PDT
Created
attachment 132308
[details]
Patch
Rob Buis
Comment 2
2012-03-16 10:30:04 PDT
Comment on
attachment 132308
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=132308&action=review
Looks good.
> Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:347 > +}
Above two function could use the same helper function, but you'd need to add a bool or enum indicating to test Email or Url.
> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:191 > + else if ((type == InputTypeEmail || type == InputTypeURL) && autoCompleteState != DOMSupport::On)
else seems unnecessary here.
WebKit Review Bot
Comment 3
2012-03-16 11:39:24 PDT
Comment on
attachment 132308
[details]
Patch Clearing flags on attachment: 132308 Committed
r111037
: <
http://trac.webkit.org/changeset/111037
>
WebKit Review Bot
Comment 4
2012-03-16 11:39:28 PDT
All reviewed patches have been landed. Closing bug.
Mike Fenton
Comment 5
2012-03-16 13:12:43 PDT
Created
attachment 132355
[details]
Follow up patch
Rob Buis
Comment 6
2012-03-16 13:13:54 PDT
Comment on
attachment 132355
[details]
Follow up patch Even better :)
Mike Fenton
Comment 7
2012-03-16 13:17:05 PDT
Created
attachment 132357
[details]
Proper follow up patch.
Rob Buis
Comment 8
2012-03-16 13:19:31 PDT
Comment on
attachment 132357
[details]
Proper follow up patch. OK.
Mike Fenton
Comment 9
2012-03-19 10:11:44 PDT
Reopen so commit bot will grab it.
WebKit Review Bot
Comment 10
2012-03-19 11:17:06 PDT
Comment on
attachment 132357
[details]
Proper follow up patch. Clearing flags on attachment: 132357 Committed
r111206
: <
http://trac.webkit.org/changeset/111206
>
WebKit Review Bot
Comment 11
2012-03-19 11:17:11 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug