Bug 81364 - [BlackBerry] Input fields with id of e-mail and url should be styled as such.
Summary: [BlackBerry] Input fields with id of e-mail and url should be styled as such.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Fenton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-16 10:08 PDT by Mike Fenton
Modified: 2012-03-19 11:17 PDT (History)
2 users (show)

See Also:


Attachments
Patch (8.16 KB, patch)
2012-03-16 10:19 PDT, Mike Fenton
no flags Details | Formatted Diff | Diff
Follow up patch (2.99 KB, patch)
2012-03-16 13:12 PDT, Mike Fenton
rwlbuis: review+
mifenton: commit-queue-
Details | Formatted Diff | Diff
Proper follow up patch. (2.95 KB, patch)
2012-03-16 13:17 PDT, Mike Fenton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Fenton 2012-03-16 10:08:07 PDT
For any input fields that are identified as email or url they should also use the appropriate style.
Comment 1 Mike Fenton 2012-03-16 10:19:02 PDT
Created attachment 132308 [details]
Patch
Comment 2 Rob Buis 2012-03-16 10:30:04 PDT
Comment on attachment 132308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132308&action=review

Looks good.

> Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:347
> +}

Above two function could use the same helper function, but you'd need to add a bool or enum indicating to test Email or Url.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:191
> +            else if ((type == InputTypeEmail || type == InputTypeURL) && autoCompleteState != DOMSupport::On)

else seems unnecessary here.
Comment 3 WebKit Review Bot 2012-03-16 11:39:24 PDT
Comment on attachment 132308 [details]
Patch

Clearing flags on attachment: 132308

Committed r111037: <http://trac.webkit.org/changeset/111037>
Comment 4 WebKit Review Bot 2012-03-16 11:39:28 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Mike Fenton 2012-03-16 13:12:43 PDT
Created attachment 132355 [details]
Follow up patch
Comment 6 Rob Buis 2012-03-16 13:13:54 PDT
Comment on attachment 132355 [details]
Follow up patch

Even better :)
Comment 7 Mike Fenton 2012-03-16 13:17:05 PDT
Created attachment 132357 [details]
Proper follow up patch.
Comment 8 Rob Buis 2012-03-16 13:19:31 PDT
Comment on attachment 132357 [details]
Proper follow up patch.

OK.
Comment 9 Mike Fenton 2012-03-19 10:11:44 PDT
Reopen so commit bot will grab it.
Comment 10 WebKit Review Bot 2012-03-19 11:17:06 PDT
Comment on attachment 132357 [details]
Proper follow up patch.

Clearing flags on attachment: 132357

Committed r111206: <http://trac.webkit.org/changeset/111206>
Comment 11 WebKit Review Bot 2012-03-19 11:17:11 PDT
All reviewed patches have been landed.  Closing bug.