Bug 81363 – [chromium] Transform animation state should be inherited from parents

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dana Jansens]

[chromium] Transform animation state should be inherited from parents

[Dana Jansens]

Created attachment 132306 [details]
Patch

[Dana Jansens]

I'm not sure if this is something we'll need to worry about being problematic, but which layers have RenderSurfaces may be different between the two threads in the face of animating opacity.

[Dana Jansens]

Created attachment 132371 [details]
Patch

- Renamed the transformIsAnimating() functions based on feedback from Shawn. I think they're more clear and consistent now.
- Moved the bugfix for creation of render surfaces out, as it's a separate issue.

[Adrienne Walker]

Comment on attachment 132371 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132371&action=review

Looks good in general.  R=me, with nits.

> Source/WebCore/platform/graphics/chromium/cc/CCRenderSurface.h:95
> +    bool targetSurfaceTransformsAreAnimating() const { return m_targetSurfaceTransformsAreAnimating; }
> +    void setTargetSurfaceTransformsAreAnimating(bool animating) { m_targetSurfaceTransformsAreAnimating = animating; }
> +    bool screenSpaceTransformsAreAnimating() const { return m_screenSpaceTransformsAreAnimating; }
> +    void setScreenSpaceTransformsAreAnimating(bool animating) { m_screenSpaceTransformsAreAnimating = animating; }

Why is screen space transform plural here? Isn't there just one?

> Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp:724
> +    EXPECT_TRUE(renderSurface2->renderSurface()->targetSurfaceTransformsAreAnimating());

Can you add a test where renderSurface()->targetSurfaceTransformsAreAnimating() is false?

> Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp:729
> +    // Verify drawTransformsAnimatingInScreen values
> +    //

Can you add a test where screenSpaceTransformIsAnimating ends up being false?

[Dana Jansens]

Comment on attachment 132371 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132371&action=review

ty :)

>> Source/WebCore/platform/graphics/chromium/cc/CCRenderSurface.h:95
>> +    void setScreenSpaceTransformsAreAnimating(bool animating) { m_screenSpaceTransformsAreAnimating = animating; }
> 
> Why is screen space transform plural here? Isn't there just one?

there is going to be one for the surface and one for the replica.

>> Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp:724
>> +    EXPECT_TRUE(renderSurface2->renderSurface()->targetSurfaceTransformsAreAnimating());
> 
> Can you add a test where renderSurface()->targetSurfaceTransformsAreAnimating() is false?

k!

>> Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp:729
>> +    //
> 
> Can you add a test where screenSpaceTransformIsAnimating ends up being false?

k!

[Dana Jansens]

Created attachment 132426 [details]
Patch

Thanks for the input, I made that test a lot better. It tests both cases with the 2 render surfaces, and tests propogation of screen space transforms by setting transforms on 2 of the 3 children of root.

[WebKit Review Bot]

Comment on attachment 132426 [details]
Patch

Clearing flags on attachment: 132426

Committed r111137: <http://trac.webkit.org/changeset/111137>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.