Bug 81360 - [chromium] Improve CSS3 filters performance for blur() and drop-shadow().
Summary: [chromium] Improve CSS3 filters performance for blur() and drop-shadow().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Stephen White
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-16 09:29 PDT by Stephen White
Modified: 2012-03-16 21:08 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.35 KB, patch)
2012-03-16 09:30 PDT, Stephen White 		no flags Details | Formatted Diff | Diff
Patch (1.83 KB, patch)
2012-03-16 09:43 PDT, Stephen White 		jamesr: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2012-03-16 09:29:11 PDT 
[chromium] Improve CSS3 filters performance for blur() and drop-shadow().
Comment 1 Stephen White 2012-03-16 09:30:45 PDT 
Created attachment 132296 [details]
Patch
Comment 2 Stephen White 2012-03-16 09:43:29 PDT 
Created attachment 132300 [details]
Patch
Comment 3 Stephen White 2012-03-16 09:44:12 PDT 
(In reply to comment #2)
> Created an attachment (id=132300) [details]
> Patch

With the previous change, drop-shadow() was showing some truncated pixels on the layout tests, so I've reverted that part of the change.
Comment 4 James Robinson 2012-03-16 12:23:31 PDT 
Comment on attachment 132300 [details]
Patch

Cool
Comment 5 Stephen White 2012-03-16 12:45:19 PDT 
Committed r111047: <http://trac.webkit.org/changeset/111047>
Comment 6 James Robinson 2012-03-16 20:39:51 PDT 
compositing/shadows/shadow-drawing.html changed behavior on windows with this patch:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showLargeExpectations=true&tests=compositing%2Fshadows%2Fshadow-drawing.html

I kinda think the new results look better, but could you take a look?
Comment 7 Stephen White 2012-03-16 21:08:56 PDT 
(In reply to comment #6)
> compositing/shadows/shadow-drawing.html changed behavior on windows with this patch:
> 
> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showLargeExpectations=true&tests=compositing%2Fshadows%2Fshadow-drawing.html
> 
> I kinda think the new results look better, but could you take a look?

This test has no -webkit-filter, so I think it must be something else.

Not sure what's going on, but if you look at the Vista results, they changed at http://trac.webkit.org/log/?verbose=on&rev=111013&stop_rev=111012.