WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
81357
build-webkit launcher instructions use wrong relative path for Qt
https://bugs.webkit.org/show_bug.cgi?id=81357
Summary
build-webkit launcher instructions use wrong relative path for Qt
Tom Zakrajsek
Reported
2012-03-16 09:07:04 PDT
build-webkit is printing the launcher-path relative to the current working directory at the end of the script, but is not taking into account that the script will exit to it's original working directory. For --qt builds, this means that the path is relative to the WebKitBuild dir and causes an extra ../ at the beginning.
Attachments
Patch
(1.28 KB, patch)
2012-03-16 14:50 PDT
,
Dave Tharp
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dave Tharp
Comment 1
2012-03-16 14:50:40 PDT
Created
attachment 132386
[details]
Patch
Tom Zakrajsek
Comment 2
2012-03-16 15:31:38 PDT
Looks good to me. Fixes the problem and get's rid of a bogus assumption.
Eric Seidel (no email)
Comment 3
2012-03-16 15:32:47 PDT
Comment on
attachment 132386
[details]
Patch OK.
WebKit Review Bot
Comment 4
2012-03-16 17:13:22 PDT
Comment on
attachment 132386
[details]
Patch Clearing flags on attachment: 132386 Committed
r111093
: <
http://trac.webkit.org/changeset/111093
>
WebKit Review Bot
Comment 5
2012-03-16 17:13:26 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug