Bug 81357 - build-webkit launcher instructions use wrong relative path for Qt
Summary: build-webkit launcher instructions use wrong relative path for Qt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Minor
Assignee: Dave Tharp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-16 09:07 PDT by Tom Zakrajsek
Modified: 2012-03-16 17:13 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.28 KB, patch)
2012-03-16 14:50 PDT, Dave Tharp 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Zakrajsek 2012-03-16 09:07:04 PDT 
build-webkit is printing the launcher-path relative to the current working directory at the end of the script, but is not taking into account that the script will exit to it's original working directory.  For --qt builds, this means that the path is relative to the WebKitBuild dir and causes an extra ../ at the beginning.
Comment 1 Dave Tharp 2012-03-16 14:50:40 PDT 
Created attachment 132386 [details]
Patch
Comment 2 Tom Zakrajsek 2012-03-16 15:31:38 PDT 
Looks good to me.  Fixes the problem and get's rid of a bogus assumption.
Comment 3 Eric Seidel (no email) 2012-03-16 15:32:47 PDT 
Comment on attachment 132386 [details]
Patch

OK.
Comment 4 WebKit Review Bot 2012-03-16 17:13:22 PDT 
Comment on attachment 132386 [details]
Patch

Clearing flags on attachment: 132386

Committed r111093: <http://trac.webkit.org/changeset/111093>
Comment 5 WebKit Review Bot 2012-03-16 17:13:26 PDT 
All reviewed patches have been landed.  Closing bug.