Implement snippets evaluation.
Created attachment 132252 [details] Patch
Comment on attachment 132252 [details] Patch looks good!
Comment on attachment 132252 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132252&action=review > Source/WebCore/inspector/front-end/ConsoleView.js:665 > + evaluateAndAppendResult: function(text) Should evaluateUsingTextPrompt accept optional parameter that allows not showing the expression in the text prompt?
Comment on attachment 132252 [details] Patch Attachment 132252 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11960375 New failing tests: inspector/debugger/snippets-model.html
Committed r111212: <http://trac.webkit.org/changeset/111212>
The inspector/debugger/snippets-model.html test fails on Qt. --- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/debugger/snippets-model-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/debugger/snippets-model-actual.txt @@ -1,3 +1,4 @@ +FAIL: Timed out waiting for notifyDone to be called Tests snippets model. @@ -37,9 +38,4 @@ Running: testEvaluate Last evaluation source url for snippet: snippets://1_1 -Snippet script added, sourceURL = snippets://1_1 -Last evaluation source url for snippet: snippets://2_2 -Snippet script added, sourceURL = snippets://2_2 -Last evaluation source url for snippet: snippets://1_3 -Snippet script added, sourceURL = snippets://1_3 I will skip this until it is fixed.
Reopen to fix it. Skipped on Qt - http://trac.webkit.org/changeset/111378/trunk/LayoutTests/platform/qt/Skipped Please unskip with the proper fix.
(In reply to comment #7) > Reopen to fix it. Skipped on Qt - http://trac.webkit.org/changeset/111378/trunk/LayoutTests/platform/qt/Skipped > > Please unskip with the proper fix. Committed r111409: <http://trac.webkit.org/changeset/111409>