WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
81313
Move parse_bug_id into config/urls in preparation for re-use elsewhere.
https://bugs.webkit.org/show_bug.cgi?id=81313
Summary
Move parse_bug_id into config/urls in preparation for re-use elsewhere.
Eric Seidel (no email)
Reported
2012-03-15 23:07:50 PDT
Move parse_bug_id into config/urls in preparation for re-use elsewhere.
Attachments
Patch
(10.32 KB, patch)
2012-03-15 23:08 PDT
,
Eric Seidel (no email)
abarth
: review+
abarth
: commit-queue+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2012-03-15 23:08:20 PDT
Created
attachment 132206
[details]
Patch
Adam Barth
Comment 2
2012-03-15 23:10:58 PDT
Comment on
attachment 132206
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=132206&action=review
> Tools/Scripts/webkitpy/common/config/urls.py:56 > +def parse_bug_id(message):
message ? Not sure what the best parameter name is here.
> Tools/Scripts/webkitpy/common/config/urls_unittest.py:35 > + def test_parse_bug_id(self):
Should we add any multiline test cases since that's needed by at least one caller.
Eric Seidel (no email)
Comment 3
2012-03-15 23:18:46 PDT
Committed
r110948
: <
http://trac.webkit.org/changeset/110948
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug