Bug 81313 - Move parse_bug_id into config/urls in preparation for re-use elsewhere.
Summary: Move parse_bug_id into config/urls in preparation for re-use elsewhere.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-15 23:07 PDT by Eric Seidel (no email)
Modified: 2012-03-15 23:18 PDT (History)
3 users (show)

See Also:

Attachments
Patch (10.32 KB, patch)
2012-03-15 23:08 PDT, Eric Seidel (no email) 		abarth: review+
abarth: commit-queue+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-03-15 23:07:50 PDT 
Move parse_bug_id into config/urls in preparation for re-use elsewhere.
Comment 1 Eric Seidel (no email) 2012-03-15 23:08:20 PDT 
Created attachment 132206 [details]
Patch
Comment 2 Adam Barth 2012-03-15 23:10:58 PDT 
Comment on attachment 132206 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132206&action=review

> Tools/Scripts/webkitpy/common/config/urls.py:56
> +def parse_bug_id(message):

message ?  Not sure what the best parameter name is here.

> Tools/Scripts/webkitpy/common/config/urls_unittest.py:35
> +    def test_parse_bug_id(self):

Should we add any multiline test cases since that's needed by at least one caller.
Comment 3 Eric Seidel (no email) 2012-03-15 23:18:46 PDT 
Committed r110948: <http://trac.webkit.org/changeset/110948>