Bug 81312 - [BlackBerry] Upstream the BlackBerry change to platform/PlatformKeyboardEvent.h
Summary: [BlackBerry] Upstream the BlackBerry change to platform/PlatformKeyboardEvent.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Leo Yang
URL:
Keywords:
Depends on:
Blocks: 73144
  Show dependency tree / graph
 
Reported: 2012-03-15 23:07 PDT by Leo Yang
Modified: 2012-03-19 09:23 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.74 KB, patch)
2012-03-15 23:56 PDT, Leo Yang 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Yang 2012-03-15 23:07:30 PDT 
BlackBerry specific change to keyboard event.
Comment 1 Leo Yang 2012-03-15 23:56:19 PDT 
Created attachment 132214 [details]
Patch
Comment 2 Build Bot 2012-03-16 00:11:10 PDT 
Comment on attachment 132214 [details]
Patch

Attachment 132214 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/11964047
Comment 3 Leo Yang 2012-03-16 00:21:40 PDT 
(In reply to comment #2)
> (From update of attachment 132214 [details])
> Attachment 132214 [details] did not pass mac-ews (mac):
> Output: http://queues.webkit.org/results/11964047

Seems not related to this patch.
Comment 4 Rob Buis 2012-03-16 04:13:32 PDT 
Comment on attachment 132214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132214&action=review

> Source/WebCore/platform/PlatformKeyboardEvent.h:195
> +        unsigned short m_unmodifiedCharacter;

How is m_unmodifiedCharacter used? It seems to be set to zero and then?
Comment 5 Leo Yang 2012-03-18 19:55:00 PDT 
(In reply to comment #4)
> (From update of attachment 132214 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=132214&action=review
> 
> > Source/WebCore/platform/PlatformKeyboardEvent.h:195
> > +        unsigned short m_unmodifiedCharacter;
> 
> How is m_unmodifiedCharacter used? It seems to be set to zero and then?

It's initialized by event.character() in PlatformKeyboardEvent::PlatformKeyboardEvent(const BlackBerry::Platform::KeyboardEvent& event) in PlatformKeyboardEventBlackBerry.cpp and used in PluginView::handleKeyboardEvent(KeyboardEvent* event) in PluginViewBlackBerry.cpp.
Comment 6 Rob Buis 2012-03-19 07:05:44 PDT 
Comment on attachment 132214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132214&action=review

LGTM.

>>> Source/WebCore/platform/PlatformKeyboardEvent.h:195
>>> +        unsigned short m_unmodifiedCharacter;
>> 
>> It's initialized by event.character() in PlatformKeyboardEvent::PlatformKeyboardEvent(const BlackBerry::Platform::KeyboardEvent& event) in PlatformKeyboardEventBlackBerry.cpp and used in PluginView::handleKeyboardEvent(KeyboardEvent* event) in PluginViewBlackBerry.cpp.
> 
> How is m_unmodifiedCharacter used? It seems to be set to zero and then?

Ah, this was not visible from the context, I saw it just now in the source file, thanks.
Comment 7 WebKit Review Bot 2012-03-19 09:23:37 PDT 
Comment on attachment 132214 [details]
Patch

Clearing flags on attachment: 132214

Committed r111191: <http://trac.webkit.org/changeset/111191>
Comment 8 WebKit Review Bot 2012-03-19 09:23:43 PDT 
All reviewed patches have been landed.  Closing bug.