RESOLVED INVALID 81294
Web Inspector: TypeBuilder: reduce raw methods visibility in generated types. 
https://bugs.webkit.org/show_bug.cgi?id=81294
Summary Web Inspector: TypeBuilder: reduce raw methods visibility in generated types.
Peter Rybin
Reported 2012-03-15 17:42:03 PDT
Currently both typed generated methods and raw setters are available for generated types. Hide raw setters so that make sure that only documented properties are set.
Attachments
Patch (46.67 KB, patch)
2012-03-15 18:01 PDT, Peter Rybin 		pfeldman: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Peter Rybin
Comment 1 2012-03-15 18:01:38 PDT
Created attachment 132166 [details] Patch
Pavel Feldman
Comment 2 2012-03-20 04:45:25 PDT
Comment on attachment 132166 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132166&action=review One nit + you should run it through EWS. > Source/WebCore/inspector/CodeGeneratorInspector.py:1229 > + //COMPILE_ASSERT(false, weird_old_code); We don't commit commented out code. > Source/WebCore/inspector/CodeGeneratorInspector.py:1247 > + // return Builder<NoFieldsSet>(adoptRef(new %s())); ditto
Radar WebKit Bug Importer
Comment 3 2014-01-26 11:12:31 PST
<rdar://problem/15911127>
Note You need to log in before you can comment on or make changes to this bug.