Bug 81294 - Web Inspector: TypeBuilder: reduce raw methods visibility in generated types.
Summary: Web Inspector: TypeBuilder: reduce raw methods visibility in generated types.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-03-15 17:42 PDT by Peter Rybin
Modified: 2016-03-13 15:03 PDT (History)
7 users (show)

See Also:

Attachments
Patch (46.67 KB, patch)
2012-03-15 18:01 PDT, Peter Rybin 		pfeldman: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Rybin 2012-03-15 17:42:03 PDT 
Currently both typed generated methods and raw setters are available for generated types. Hide raw setters so that make sure that only documented properties are set.
Comment 1 Peter Rybin 2012-03-15 18:01:38 PDT 
Created attachment 132166 [details]
Patch
Comment 2 Pavel Feldman 2012-03-20 04:45:25 PDT 
Comment on attachment 132166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132166&action=review

One nit + you should run it through EWS.

> Source/WebCore/inspector/CodeGeneratorInspector.py:1229
> +            //COMPILE_ASSERT(false, weird_old_code);

We don't commit commented out code.

> Source/WebCore/inspector/CodeGeneratorInspector.py:1247
> +        // return Builder<NoFieldsSet>(adoptRef(new %s()));

ditto
Comment 3 Radar WebKit Bug Importer 2014-01-26 11:12:31 PST 
<rdar://problem/15911127>