Bug 81293 - REGRESSION(r110595): webkit-patch suggest-reviewers doesn't work
Summary: REGRESSION(r110595): webkit-patch suggest-reviewers doesn't work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-15 17:34 PDT by Kent Tamura
Modified: 2012-03-15 17:53 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.77 KB, patch)
2012-03-15 17:43 PDT, Kent Tamura 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-03-15 17:34:44 PDT 
http://trac.webkit.org/changeset/110595

_split_contributor_names() doesn't handle && as a separator.

Traceback (most recent call last):
  File "./Tools/Scripts/webkit-patch", line 69, in <module>
    main()
  File "./Tools/Scripts/webkit-patch", line 64, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 311, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 120, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/tool/commands/queries.py", line 59, in execute
    reviewers = tool.checkout().suggested_reviewers(options.git_commit)
  File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 139, in suggested_reviewers
    commit_infos = self.recent_commit_infos_for_files(changed_files)
  File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 135, in recent_commit_infos_for_files
    return set(map(self.commit_info_for_revision, revisions))
  File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/common/memoized.py", line 45, in __call__
    result = self._function(*args)
  File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 102, in co
    changelog_data = self._changelog_data_for_revision(revision)
  File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 82, in _changelog_data_for_revision
    changelog_entries = self.changelog_entries_for_revision(revision, changed_files=changed_files)
  File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 75, in changelog_entries_for_revision
    changelog_entries.append(self._latest_entry_for_changelog_at_revision(path, revision))
  File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 61, in _latest_entry_for_changelog_at_revision
    return ChangeLog.parse_latest_entry_from_file(changelog_file)
  File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 266, in parse_latest_entry_from_file
    return ChangeLogEntry(''.join(entry_lines[:-1]))
  File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 118, in __init__
    self._parse_entry()
  File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 183, in _parse_entry
    self._authors = ChangeLogEntry._parse_author_text(self._author_text)
  File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 174, in _parse_author_text
    return [ChangeLogEntry._parse_author_name_and_email(author) for author in authors]
  File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 164, in _parse_author_name_and_email
    return {'name': match.group("name"), 'email': match.group("email")}
AttributeError: 'NoneType' object has no attribute 'group'
Comment 1 Kent Tamura 2012-03-15 17:43:03 PDT 
Created attachment 132162 [details]
Patch
Comment 2 Kent Tamura 2012-03-15 17:53:46 PDT 
Committed r110922: <http://trac.webkit.org/changeset/110922>