WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
81278
[WinCairo] Correct <wtf/*.h> include paths
https://bugs.webkit.org/show_bug.cgi?id=81278
Summary
[WinCairo] Correct <wtf/*.h> include paths
Brent Fulgham
Reported
2012-03-15 15:34:33 PDT
Various Cairo source files include 'wtf' components without including the 'wtf' directory structure in the path. This causes problems for the WinCairo build because the standard include paths for the main Apple port do not include the 'wtf' subdirectories. WebKit policy has been clarified such that the proper include path format should include the 'wtf' directory structure when including these files. This patch updates a handful of Cairo-related files that did not include 'wtf' in the #include declarations, causing build failures.
Attachments
Update to correct include paths.
(2.14 KB, patch)
2012-03-15 15:37 PDT
,
Brent Fulgham
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2012-03-15 15:37:05 PDT
Created
attachment 132135
[details]
Update to correct include paths.
Eric Seidel (no email)
Comment 2
2012-03-15 15:38:49 PDT
Comment on
attachment 132135
[details]
Update to correct include paths. LGTM.
Brent Fulgham
Comment 3
2012-03-15 18:01:34 PDT
Landed in
r110910
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug