Bug 81271 - WebViewImpl.cpp should no include my mother's kitchen sink
Summary: WebViewImpl.cpp should no include my mother's kitchen sink
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-15 14:55 PDT by Eric Seidel (no email)
Modified: 2024-03-11 09:19 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-03-15 14:55:56 PDT
WebViewImpl.cpp should no include my mother's kitchen sink

Any time one has 124 #include statements in a file... well... "we're doing it wrong". :)
Comment 1 Ahmad Saleem 2024-03-10 19:33:53 PDT
Is it for `WebViewImpl.mm` since WebKit don't have `WebViewImpl.cpp`?

https://searchfox.org/wubkat/rev/c67bb750f2c1083399f0dbe7d08b416cd45eee34/Source/WebKit/UIProcess/mac/WebViewImpl.mm

@Alexey - any input?
Comment 2 Alexey Proskuryakov 2024-03-11 09:19:32 PDT
We've had several include hygiene projects completed since then, this bug is not serving any purpose at this point.