Out-of-document radio buttons should be grouped when associated with a form
Created attachment 132125 [details] Patch
Comment on attachment 132125 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132125&action=review > Source/WebCore/ChangeLog:65 > + * dom/CheckedRadioButtons.cpp: > + (WebCore): > + (WebCore::CheckedRadioButtons::addButton): > + (WebCore::CheckedRadioButtons::updateCheckedState): > + (WebCore::CheckedRadioButtons::requiredAttributeChanged): > + (WebCore::CheckedRadioButtons::isRequiredGroup): > + (WebCore::CheckedRadioButtons::removeButton): > + * dom/CheckedRadioButtons.h: > + (CheckedRadioButtons): > + * html/HTMLInputElement.cpp: > + (WebCore::HTMLInputElement::~HTMLInputElement): > + (WebCore::HTMLInputElement::updateType): > + (WebCore::HTMLInputElement::parseAttribute): > + (WebCore::HTMLInputElement::setChecked): > + (WebCore::HTMLInputElement::willChangeForm): > + (WebCore::HTMLInputElement::didChangeForm): > + (WebCore::HTMLInputElement::insertedIntoDocument): > + (WebCore::HTMLInputElement::removedFromDocument): > + (WebCore::HTMLInputElement::didMoveToNewDocument): > + (WebCore::HTMLInputElement::requiredAttributeChanged): > + (WebCore::HTMLInputElement::isInRequiredRadioButtonGroup): > + (WebCore): > + (WebCore::HTMLInputElement::checkedRadioButtonForGroup): > + (WebCore::HTMLInputElement::checkedRadioButtons): > + (WebCore::HTMLInputElement::addRadioButton): > + (WebCore::HTMLInputElement::removeRadioButton): > + * html/HTMLInputElement.h: > + (HTMLInputElement): > + * html/RadioInputType.cpp: > + (WebCore::RadioInputType::valueMissing): > + (WebCore::RadioInputType::isKeyboardFocusable): > + (WebCore::RadioInputType::willDispatchClick): You had better add what is changed for each files/functions. > Source/WebCore/html/HTMLInputElement.h:345 > + void addRadioButton(); > + void removeRadioButton(); I'd like to name them: addToRadioButtonGroup() removeFromRadioButtonGroup()
Created attachment 132321 [details] Patch for landing
Comment on attachment 132321 [details] Patch for landing Clearing flags on attachment: 132321 Committed r111051: <http://trac.webkit.org/changeset/111051>
All reviewed patches have been landed. Closing bug.