Bug 81245 - Web Inspector: crash in InspectorTimelineAgent when trying to add children to cancelable records
Summary: Web Inspector: crash in InspectorTimelineAgent when trying to add children to...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-15 11:32 PDT by Andrey Kosyakov
Modified: 2012-03-15 12:30 PDT (History)
10 users (show)

See Also:

Attachments
Patch (3.89 KB, patch)
2012-03-15 11:58 PDT, Andrey Kosyakov 		vsevik: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-03-15 11:32:23 PDT 
Cancelable records are not expected to have children, since they may be cancelled. pushGCEventRecords() used to indirectly add children to cancelable records by invoking addRecordToTimeline().
We should always commit cancelable records before trying to add children.
Comment 1 Andrey Kosyakov 2012-03-15 11:58:09 PDT 
Created attachment 132096 [details]
Patch
Comment 2 Andrey Kosyakov 2012-03-15 12:30:52 PDT 
Committed r110872: <http://trac.webkit.org/changeset/110872>