Build failure due to inconsistent use of TOUCH_EVENTS flag.
Created attachment 132082 [details] Patch
There are many methods/files that can be wrapped in ENABLE_TOUCH_EVENTS flag. The patch fixes only the inconsistent places that specifically caused the build to fail.
Comment on attachment 132082 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132082&action=review > Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp:233 > + Q_UNUSED(point); Shouldn't this be in #else?
(In reply to comment #3) > (From update of attachment 132082 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=132082&action=review > > > Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp:233 > > + Q_UNUSED(point); > > Shouldn't this be in #else? Yes :)
Created attachment 132117 [details] Patch for landing
Comment on attachment 132117 [details] Patch for landing Rejecting attachment 132117 [details] from commit-queue. maheshk@webkit.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Comment on attachment 132117 [details] Patch for landing Clearing flags on attachment: 132117 Committed r111010: <http://trac.webkit.org/changeset/111010>
All reviewed patches have been landed. Closing bug.