Bug 81241 – [Qt][WK2] Build failure when using --no-touch-events

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Dinu Jacob]

Build failure due to inconsistent use of TOUCH_EVENTS flag.

[Dinu Jacob]

Created attachment 132082 [details]
Patch

[Dinu Jacob]

There are many methods/files that can be wrapped in ENABLE_TOUCH_EVENTS flag. The patch fixes only the inconsistent places that specifically caused the build to fail.

[Simon Hausmann]

Comment on attachment 132082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132082&action=review

> Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp:233
> +    Q_UNUSED(point);

Shouldn't this be in #else?

[Dinu Jacob]

(In reply to comment #3)
> (From update of attachment 132082 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=132082&action=review
> 
> > Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp:233
> > +    Q_UNUSED(point);
> 
> Shouldn't this be in #else?

Yes :)

[Dinu Jacob]

Created attachment 132117 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 132117 [details]
Patch for landing

Rejecting attachment 132117 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Review Bot]

Comment on attachment 132117 [details]
Patch for landing

Clearing flags on attachment: 132117

Committed r111010: <http://trac.webkit.org/changeset/111010>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.