Bug 81229 - [GTK] WebKitWebResource::load-failed uses the wrong marshaller
Summary: [GTK] WebKitWebResource::load-failed uses the wrong marshaller
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-15 09:55 PDT by Victor Lucero
Modified: 2012-03-16 11:00 PDT (History)
3 users (show)

See Also:


Attachments
partch to fix typo (495 bytes, patch)
2012-03-15 10:29 PDT, Victor Lucero
no flags Details | Formatted Diff | Diff
Patch (1.37 KB, patch)
2012-03-16 09:08 PDT, Victor Lucero
no flags Details | Formatted Diff | Diff
Patch (1.37 KB, patch)
2012-03-16 09:17 PDT, Victor Lucero
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Lucero 2012-03-15 09:55:03 PDT
bug detected when signal "load-failed" is trigged with a resource object

error displayed by glib when the signal is triggered
GLib-GObject-CRITICAL **: g_value_get_object: assertion `G_VALUE_HOLDS_OBJECT (value)' failed

if signal is trigger by WebkitWebView ("resource-load-failed") or WebkitWebFrame the pointer is called w/o problemsand there is no error

already fixed , i will submit the patch
Comment 1 Victor Lucero 2012-03-15 10:29:22 PDT
Created attachment 132073 [details]
partch to fix typo

here is the patch i make with the correction
hope this help
Comment 2 Victor Lucero 2012-03-16 09:08:07 PDT
Created attachment 132292 [details]
Patch
Comment 3 WebKit Review Bot 2012-03-16 09:10:26 PDT
Attachment 132292 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/gtk/ChangeLog', u'Source/Web..." exit_code: 1
Source/WebKit/gtk/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Victor Lucero 2012-03-16 09:17:23 PDT
Created attachment 132294 [details]
Patch
Comment 5 WebKit Review Bot 2012-03-16 11:00:26 PDT
Comment on attachment 132294 [details]
Patch

Clearing flags on attachment: 132294

Committed r111027: <http://trac.webkit.org/changeset/111027>
Comment 6 WebKit Review Bot 2012-03-16 11:00:31 PDT
All reviewed patches have been landed.  Closing bug.